Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0.0-M1
    • Component/s: wicket-extensions
    • Labels:
      None
    • Environment:
      any

      Description

      Hi!

      I want to suggest an enhancement for the DataTable extension.

      Right now it's only possible to style columns (width, alignment, color etc.) via stylesheets. This has some not so nice implications IMHO:

      • You have to extend the IStyledColumn to return the proper CSS class.
      • You have to add a bunch of CSS classes to get the proper styles.
      • You have redundancy in HTML output - which isn't necessary.

      This is actually what <colgroup><col></colgroup> is meant to solve.

      My suggestion:

      Adding a 'addColGroup( ColGroup cg )'-feature, which actually lets you add x ColGroups with n Cols on which you can use AttributeModifiers to have your styles/classes/width-Attributes added.

      A quick implementation would be this:

      --[ColGroup.java]-
      import java.util.List;

      import org.apache.wicket.behavior.IBehavior;
      import org.apache.wicket.extensions.markup.html.repeater.data.table.AbstractToolbar;
      import org.apache.wicket.extensions.markup.html.repeater.data.table.DataTable;
      import org.apache.wicket.markup.html.WebMarkupContainer;
      import org.apache.wicket.markup.repeater.RepeatingView;

      public class ColGroup
      extends AbstractToolbar
      {
      private static final long serialVersionUID = 1L;

      private int numCols;
      private Col[] cols;

      public ColGroup( DataTable datatable, int numCols )

      { super( datatable ); this.numCols = numCols; }

      public void onBeforeRender()
      {
      if( !hasBeenRendered() )
      {
      WebMarkupContainer colgroup = new WebMarkupContainer( "colgroup" );
      for( IBehavior b : (List<IBehavior>) getBehaviors() )
      colgroup.add( b );
      setRenderBodyOnly( true );
      removeAll();
      add( colgroup );

      RepeatingView colgroupCols = new RepeatingView( "elements" );
      colgroup.add( colgroupCols );

      for( Col column : getCols() )

      { WebMarkupContainer item = new WebMarkupContainer( colgroupCols.newChildId() ); colgroupCols.add( item ); item.add( column ); }

      }
      super.onBeforeRender();
      }

      public final Col[] getCols( )
      {
      if( cols == null )

      { cols = new Col[numCols]; for( int i = 0; i < numCols; i++ ) cols[i] = new Col(); }

      return(cols);
      }

      public final class Col
      extends WebMarkupContainer
      {
      private static final long serialVersionUID = 1L;

      private Col()

      { super( "col" ); }

      }

      }
      --[/ColGroup.java]-

      --[ColGroup.html]-
      <wicket:panel>
      <colgroup wicket:id="colgroup">
      <wicket:container wicket:id="elements"><col wicket:id="col"/></wicket:container>
      </colgroup>
      </wicket:panel>
      --[/ColGroup.html]-

      Usage:

      ColGroup colgroup = new ColGroup( datatable, 4 );
      colgroup.add( new SimpleAttributeModifier( "style", "border: solid 1px green;" ) );
      Col[] cols = colgroup.getCols();
      cols[0].add( new SimpleAttributeModifier( "width", "10%" ) );
      cols[1].add( new SimpleAttributeModifier( "width", "35%" ) );
      cols[2].add( new SimpleAttributeModifier( "width", "45%" ) );
      cols[3].add( new SimpleAttributeModifier( "width", "10%" ) );
      datatable.addColGroup( colgroup );

      Any thoughts?

      Regards, — Jan.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit edcbd4e849378a5aba9ee2d5e4f954bce904af52 in wicket's branch refs/heads/wicket-6.x from Sven Meier
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=edcbd4e ]

          WICKET-5925 removed code left from WICKET-1069

          Show
          ASF subversion and git services added a comment - Commit edcbd4e849378a5aba9ee2d5e4f954bce904af52 in wicket's branch refs/heads/wicket-6.x from Sven Meier [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=edcbd4e ] WICKET-5925 removed code left from WICKET-1069
          Hide
          Igor Vaynberg added a comment -

          move new features to 1.5

          Show
          Igor Vaynberg added a comment - move new features to 1.5
          Hide
          Martijn Dashorst added a comment -

          Moved to next milestone release.

          Show
          Martijn Dashorst added a comment - Moved to next milestone release.
          Hide
          Matej Knopp added a comment -

          Postponing as this should not delay the 1.3 release

          Show
          Matej Knopp added a comment - Postponing as this should not delay the 1.3 release
          Hide
          Eelco Hillenius added a comment -

          Assigned version (beta 4)

          Show
          Eelco Hillenius added a comment - Assigned version (beta 4)
          Hide
          Igor Vaynberg added a comment -

          matej, you said we might want to put this in? even though it doesnt always work in mozilla browsers as pointed out on the list?

          Show
          Igor Vaynberg added a comment - matej, you said we might want to put this in? even though it doesnt always work in mozilla browsers as pointed out on the list?

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Jan Kriesten
            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development