Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: contrib/python
    • Labels:
      None

      Description

      There is no easy way currently to run the Python unit tests for the cloud contrib.

      1. HADOOP-6426.patch
        44 kB
        Tom White
      2. HADOOP-6426.patch
        46 kB
        Tom White
      3. HADOOP-6426.patch
        46 kB
        Tom White
      4. HADOOP-6426.patch
        46 kB
        Tom White

        Activity

        Tom White created issue -
        Hide
        Tom White added a comment -

        Here's a patch which introduces a build.xml file to run unit tests using PyAnt (based on the code in Avro which does a similar thing).

        I have changed the module that the tests are in to be different from the code it is testing (hadoop.cloud), since Python does not permit a module to be split between two directory trees. I also changed the directory structure slightly, so the python tests are in 'test/py', not 'test'.

        Show
        Tom White added a comment - Here's a patch which introduces a build.xml file to run unit tests using PyAnt (based on the code in Avro which does a similar thing). I have changed the module that the tests are in to be different from the code it is testing (hadoop.cloud), since Python does not permit a module to be split between two directory trees. I also changed the directory structure slightly, so the python tests are in 'test/py', not 'test'.
        Tom White made changes -
        Field Original Value New Value
        Attachment HADOOP-6426.patch [ 12427528 ]
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12427528/HADOOP-6426.patch
        against trunk revision 888998.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427528/HADOOP-6426.patch against trunk revision 888998. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/183/console This message is automatically generated.
        Hide
        Aaron Kimball added a comment -

        Changes look reasonable. Should this be added to the test target in src/contrib/build.xml too?

        Show
        Aaron Kimball added a comment - Changes look reasonable. Should this be added to the test target in src/contrib/build.xml too?
        Hide
        Tom White added a comment -

        Modified patch to change src/contrib/build.xml. This file was incorrectly referencing some projects that have been moved to MapReduce as a part of the project split, and hence Common contrib tests were not being run. I have excluded HOD since it needs more work to get it to run tests - I'll open a separate JIRA for that.

        Show
        Tom White added a comment - Modified patch to change src/contrib/build.xml. This file was incorrectly referencing some projects that have been moved to MapReduce as a part of the project split, and hence Common contrib tests were not being run. I have excluded HOD since it needs more work to get it to run tests - I'll open a separate JIRA for that.
        Tom White made changes -
        Attachment HADOOP-6426.patch [ 12427744 ]
        Tom White made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12427744/HADOOP-6426.patch
        against trunk revision 889378.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/196/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427744/HADOOP-6426.patch against trunk revision 889378. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/196/console This message is automatically generated.
        Hide
        Tom White added a comment -

        Properly formatted patch.

        Show
        Tom White added a comment - Properly formatted patch.
        Tom White made changes -
        Attachment HADOOP-6426.patch [ 12427746 ]
        Tom White made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12427746/HADOOP-6426.patch
        against trunk revision 889378.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427746/HADOOP-6426.patch against trunk revision 889378. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/197/console This message is automatically generated.
        Hide
        Tom White added a comment -

        Contrib tests failed because Hudson couldn't pick up the PyAnt task. New patch to alleviate this.

        Show
        Tom White added a comment - Contrib tests failed because Hudson couldn't pick up the PyAnt task. New patch to alleviate this.
        Tom White made changes -
        Attachment HADOOP-6426.patch [ 12427777 ]
        Tom White made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12427777/HADOOP-6426.patch
        against trunk revision 889378.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427777/HADOOP-6426.patch against trunk revision 889378. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/console This message is automatically generated.
        Tom White made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Tom White added a comment -

        Trying again with pyAntTasks jar now committed (it's not in any Maven repos).

        Show
        Tom White added a comment - Trying again with pyAntTasks jar now committed (it's not in any Maven repos).
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Tom White made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12427777/HADOOP-6426.patch
        against trunk revision 890410.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427777/HADOOP-6426.patch against trunk revision 890410. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/202/console This message is automatically generated.
        Hide
        Tom White added a comment -

        This is failing because Hudson doesn't have the necessary python dependencies installed (simplejson, boto). I would like to go with the original version of this patch and solve the Hudson build integration in another JIRA.

        Show
        Tom White added a comment - This is failing because Hudson doesn't have the necessary python dependencies installed (simplejson, boto). I would like to go with the original version of this patch and solve the Hudson build integration in another JIRA.
        Hide
        Tom White added a comment -

        I've just committed the original version of this.

        I've opened HADOOP-6451 to address the problem of contrib tests not being run.

        Show
        Tom White added a comment - I've just committed the original version of this. I've opened HADOOP-6451 to address the problem of contrib tests not being run.
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314296 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #119 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/119/)
        . Create ant build for running EC2 unit tests.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #119 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/119/ ) . Create ant build for running EC2 unit tests.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #190 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/190/)
        . Create ant build for running EC2 unit tests.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #190 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/190/ ) . Create ant build for running EC2 unit tests.
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.22.0 [ 12314296 ]
        Tom White made changes -
        Project Hadoop Common [ 12310240 ] Whirr [ 12311110 ]
        Key HADOOP-6426 WHIRR-8
        Workflow no-reopen-closed, patch-avail [ 12484273 ] jira [ 12512602 ]
        Hadoop Flags [Reviewed]
        Component/s contrib/cloud [ 12311822 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Tom White made changes -
        Fix Version/s 0.1.0 [ 12315111 ]
        Component/s contrib/python [ 12313573 ]
        Doug Cutting made changes -
        Workflow jira [ 12512602 ] no-reopen-closed, patch-avail [ 12512760 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        4d 22h 50m 5 Tom White 14/Dec/09 21:33
        Open Open Patch Available Patch Available
        21m 54s 6 Tom White 14/Dec/09 21:33
        Patch Available Patch Available Resolved Resolved
        2d 3h 16m 1 Tom White 17/Dec/09 00:50

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development