Whirr
  1. Whirr
  2. WHIRR-449

slf4j impl is not being copied to the lib dir when executing the binary assembly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: build
    • Labels:
      None
    1. WHIRR-449.patch
      0.5 kB
      David Alves

      Activity

      David Alves created issue -
      David Alves made changes -
      Field Original Value New Value
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      David Alves added a comment -

      changes the bin assembly so that it only outputs the whirr-cli dependencies, as a bonus the build is a bit faster.

      Show
      David Alves added a comment - changes the bin assembly so that it only outputs the whirr-cli dependencies, as a bonus the build is a bit faster.
      David Alves made changes -
      Attachment WHIRR-449.patch [ 12507436 ]
      Hide
      Andrei Savu added a comment -

      Thanks David. I will give it a try now and if everything looks fine I will build a new RC.

      Show
      Andrei Savu added a comment - Thanks David. I will give it a try now and if everything looks fine I will build a new RC.
      Hide
      Andrei Savu added a comment -

      +1 the binary release seems to be working fine. I will commit this to trunk and branch-0.7 and build a new RC.

      Show
      Andrei Savu added a comment - +1 the binary release seems to be working fine. I will commit this to trunk and branch-0.7 and build a new RC.
      Hide
      Alex Heneveld added a comment -

      +1 Good thinking & good fix David. Curious that the test scope is apparently trumping runtime and excluding the log4j dependencies – but I guess a bug in assembly that is ignored because best practice is just to include one module anyway.

      Show
      Alex Heneveld added a comment - +1 Good thinking & good fix David. Curious that the test scope is apparently trumping runtime and excluding the log4j dependencies – but I guess a bug in assembly that is ignored because best practice is just to include one module anyway.
      Hide
      Andrei Savu added a comment -

      Committed to trunk and branch 0.7.

      Show
      Andrei Savu added a comment - Committed to trunk and branch 0.7.
      Andrei Savu made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Fix Version/s 0.7.0 [ 12317571 ]
      Fix Version/s 0.8.0 [ 12318880 ]
      Resolution Fixed [ 1 ]

        People

        • Assignee:
          David Alves
          Reporter:
          David Alves
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Due:
            Created:
            Updated:
            Resolved:

            Development