Whirr
  1. Whirr
  2. WHIRR-298

Use all cluster spec properties for hash and equality

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      I forgot to add the new properties to the hash and to equals in WHIRR-288.

      1. WHIRR-298.patch
        3 kB
        Tom White
      2. WHIRR-298.patch
        2 kB
        Andrei Savu

        Activity

        Andrei Savu created issue -
        Hide
        Andrei Savu added a comment -

        Trivial patch. Sorry for missing this.

        Show
        Andrei Savu added a comment - Trivial patch. Sorry for missing this.
        Andrei Savu made changes -
        Field Original Value New Value
        Attachment WHIRR-298.patch [ 12478278 ]
        Andrei Savu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Tom White added a comment -

        Added a few more missing properties and reformatted hashCode() to make it easier to compare.

        Show
        Tom White added a comment - Added a few more missing properties and reformatted hashCode() to make it easier to compare.
        Tom White made changes -
        Attachment WHIRR-298.patch [ 12478368 ]
        Hide
        Andrei Savu added a comment -

        +1

        Show
        Andrei Savu added a comment - +1
        Hide
        Andrei Savu added a comment -

        I've just committed this. I'm going to do more work around ClusterSpec class in WHIRR-61. Thanks Tom for improving the patch.

        Show
        Andrei Savu added a comment - I've just committed this. I'm going to do more work around ClusterSpec class in WHIRR-61 . Thanks Tom for improving the patch.
        Andrei Savu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Andrei Savu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development