Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: core
    • Labels:
      None

      Description

      Add a new factory class that could be used to create BlobStoreContext instances based on configuration options provided by ClusterSpec.

      1. WHIRR-279.patch
        11 kB
        Andrei Savu
      2. WHIRR-279.patch
        12 kB
        Andrei Savu

        Issue Links

          Activity

          Gavin made changes -
          Link This issue is depended upon by WHIRR-280 [ WHIRR-280 ]
          Gavin made changes -
          Link This issue blocks WHIRR-280 [ WHIRR-280 ]
          Andrei Savu made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Andrei Savu added a comment -

          I've just committed this.

          Show
          Andrei Savu added a comment - I've just committed this.
          Hide
          Andrei Savu added a comment -

          Adrian, thanks for the tip. I've implemented the suggested approach in a new patch I've created for WHIRR-280.

          Show
          Andrei Savu added a comment - Adrian, thanks for the tip. I've implemented the suggested approach in a new patch I've created for WHIRR-280 .
          Hide
          Adrian Cole added a comment -

          @andrei even within the same provider, the location ids between compute and blobstore can be different. Ex. in S3 there is us-standard location which is "" and implicitly including ec2 east and west.

          The challenge is this.. use node.getLocation.isoCodes() then.. search through blobstore.getAssignableLocations until you find one that has the same codes as node has. This will get you the right location in a portable way.

          Show
          Adrian Cole added a comment - @andrei even within the same provider, the location ids between compute and blobstore can be different. Ex. in S3 there is us-standard location which is "" and implicitly including ec2 east and west. The challenge is this.. use node.getLocation.isoCodes() then.. search through blobstore.getAssignableLocations until you find one that has the same codes as node has. This will get you the right location in a portable way.
          Andrei Savu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Andrei Savu made changes -
          Attachment WHIRR-279.patch [ 12476337 ]
          Hide
          Andrei Savu added a comment -

          Fixed patch (moved default values for blob store identity and credential from .properties file to ClusterSpec getters).

          Adrian is it possible to setup a default location for a BlobStoreContext when the instance is created? (I've only looked at the javadoc files).

          Show
          Andrei Savu added a comment - Fixed patch (moved default values for blob store identity and credential from .properties file to ClusterSpec getters). Adrian is it possible to setup a default location for a BlobStoreContext when the instance is created? (I've only looked at the javadoc files).
          Andrei Savu made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Andrei Savu added a comment -

          It seems like the CLI unit tests are failing. I will submit a new version soon.

          Show
          Andrei Savu added a comment - It seems like the CLI unit tests are failing. I will submit a new version soon.
          Andrei Savu made changes -
          Link This issue blocks WHIRR-280 [ WHIRR-280 ]
          Andrei Savu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Andrei Savu made changes -
          Field Original Value New Value
          Attachment WHIRR-279.patch [ 12476233 ]
          Hide
          Andrei Savu added a comment -

          Created a new class and added a basic unit test.

          Show
          Andrei Savu added a comment - Created a new class and added a basic unit test.
          Andrei Savu created issue -

            People

            • Assignee:
              Andrei Savu
              Reporter:
              Andrei Savu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development