Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: core
    • Labels:
      None

      Description

      Currently the script locations are hard-coded to an EC2 bucket. We should make this configurable.

      1. WHIRR-26.patch
        1 kB
        Jeff Hammerbacher

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          +1 I moved the scripts to http://whirr.s3.amazonaws.com/ and ran the zookeeper test to manually verify this patch.

          I've just committed this. Thanks, Jeff!

          I shall write a unit test for RunUrlBuilder as a part of WHIRR-22.

          Show
          Tom White added a comment - +1 I moved the scripts to http://whirr.s3.amazonaws.com/ and ran the zookeeper test to manually verify this patch. I've just committed this. Thanks, Jeff! I shall write a unit test for RunUrlBuilder as a part of WHIRR-22 .
          Hide
          Jeff Hammerbacher added a comment -

          I was able to successfully start a cluster, run a job, and bring it down with -Dwhirr.runurl.base=http://cloudera-tom.s3.amazonaws.com. Tom is going to move the scripts to the default S3 bucket of http://whirr.s3.amazonaws.com tonight.

          Show
          Jeff Hammerbacher added a comment - I was able to successfully start a cluster, run a job, and bring it down with -Dwhirr.runurl.base= http://cloudera-tom.s3.amazonaws.com . Tom is going to move the scripts to the default S3 bucket of http://whirr.s3.amazonaws.com tonight.
          Hide
          Jeff Hammerbacher added a comment -

          The attached patch allows the user to set a Java system property called whirr.runurl.base which will be prepended to all "urls" submitted to RunUrlBuilder. Note that we now require that the protocol (http://) be specified for this prefix, as the java.net.URL constructor expects a protocol to be supplied even if runurl/wget do not require it; I could change to handle that case for the user as well, but it felt a bit magical to do two rounds of URL scrubbing.

          There are currently no tests for Whirr core, so I did not add a test for this new behavior. Once there's a unit testing framework in place, I might just use it, but I don't feel comfortable adding the first test.

          Show
          Jeff Hammerbacher added a comment - The attached patch allows the user to set a Java system property called whirr.runurl.base which will be prepended to all "urls" submitted to RunUrlBuilder. Note that we now require that the protocol ( http:// ) be specified for this prefix, as the java.net.URL constructor expects a protocol to be supplied even if runurl/wget do not require it; I could change to handle that case for the user as well, but it felt a bit magical to do two rounds of URL scrubbing. There are currently no tests for Whirr core, so I did not add a test for this new behavior. Once there's a unit testing framework in place, I might just use it, but I don't feel comfortable adding the first test.

            People

            • Assignee:
              Jeff Hammerbacher
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development