Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      Right now cluster state is written and read from the ~/.whirr/cluster-name/instances file and logic to write and update it is spread between the Service and DestroyInstanceCommand (that I know of).

      Since for WHIRR-214 the file must be updated (in another class) and for WHIRR-238 an altogether different method of storing cluster state will be required I think it might be time to move the read/write state logic to its own file (or factory in the future).

      I'll attach a very preliminary patch just to get some feedback.

      1. WHIRR-246.patch
        7 kB
        David Alves
      2. WHIRR-246.patch
        11 kB
        David Alves
      3. WHIRR-246.patch
        17 kB
        Andrei Savu
      4. WHIRR-246.patch
        27 kB
        Andrei Savu

        Issue Links

          Activity

          Gavin made changes -
          Link This issue depends upon WHIRR-173 [ WHIRR-173 ]
          Gavin made changes -
          Link This issue depends on WHIRR-173 [ WHIRR-173 ]
          Andrei Savu made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.5.0 [ 12316248 ]
          Resolution Fixed [ 1 ]
          Andrei Savu made changes -
          Link This issue blocks WHIRR-289 [ WHIRR-289 ]
          Andrei Savu made changes -
          Link This issue blocks WHIRR-288 [ WHIRR-288 ]
          Andrei Savu made changes -
          Attachment WHIRR-246.patch [ 12477657 ]
          Andrei Savu made changes -
          Attachment WHIRR-246.patch [ 12477564 ]
          Andrei Savu made changes -
          Link This issue depends on WHIRR-173 [ WHIRR-173 ]
          Andrei Savu made changes -
          Assignee Andrei Savu [ savu.andrei ]
          David Alves made changes -
          Attachment WHIRR-246.patch [ 12472684 ]
          David Alves made changes -
          Attachment WHIRR-246.patch [ 12472640 ]
          David Alves made changes -
          Field Original Value New Value
          Status Open [ 1 ] Patch Available [ 10002 ]
          David Alves created issue -

            People

            • Assignee:
              Andrei Savu
              Reporter:
              David Alves
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development