Whirr
  1. Whirr
  2. WHIRR-206

[HBase] Extract strings to a HBaseServiceConstants interface

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.3.0
    • Component/s: None
    • Labels:
      None

      Description

      This is trivial but makes sense to find common usages of the same values.

      1. WHIRR-206.patch
        11 kB
        Lars George
      2. WHIRR-206.patch
        12 kB
        Lars George
      3. WHIRR-206.patch
        11 kB
        Lars George

        Issue Links

          Activity

          Hide
          Lars George added a comment -

          Moves common strings into a separate file to enable better dependency checks.

          Show
          Lars George added a comment - Moves common strings into a separate file to enable better dependency checks.
          Hide
          Andrei Savu added a comment -

          I am unable to apply the patch to the trunk.

          Show
          Andrei Savu added a comment - I am unable to apply the patch to the trunk.
          Hide
          Lars George added a comment -

          Hmm, I rebased, so should have been current. Could you paste the error? I will try on trunk too though.

          Show
          Lars George added a comment - Hmm, I rebased, so should have been current. Could you paste the error? I will try on trunk too though.
          Hide
          Tom White added a comment -

          The recommendation from "Effective Java" is to avoid using an interface for constants (since interfaces should be used for behaviour), and instead use a class with static imports. Could we do that here?

          Show
          Tom White added a comment - The recommendation from "Effective Java" is to avoid using an interface for constants (since interfaces should be used for behaviour), and instead use a class with static imports. Could we do that here?
          Hide
          Lars George added a comment -

          Redone patch, sorry for the hassle.

          Show
          Lars George added a comment - Redone patch, sorry for the hassle.
          Hide
          Lars George added a comment -

          Oh, missed your comment. Bummer.

          OK, I'll redo the lot ;(

          Show
          Lars George added a comment - Oh, missed your comment. Bummer. OK, I'll redo the lot ;(
          Hide
          Lars George added a comment -

          Wrong usage of interface. Redo as class.

          Show
          Lars George added a comment - Wrong usage of interface. Redo as class.
          Hide
          Lars George added a comment -

          Refactored to use class instead of interface.

          Show
          Lars George added a comment - Refactored to use class instead of interface.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Lars!

          Show
          Tom White added a comment - I've just committed this. Thanks Lars!

            People

            • Assignee:
              Lars George
              Reporter:
              Lars George
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development