Whirr
  1. Whirr
  2. WHIRR-162

DnsUtilTest fails when offline or for slow connections

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.3.0
    • Component/s: service/hadoop
    • Labels:
      None

      Description

      Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.

      1. WHIRR-162.patch
        2 kB
        Andrei Savu
      2. WHIRR-162.patch
        1 kB
        Andrei Savu

        Activity

        Hide
        Andrei Savu added a comment -

        +1 for making this an integration test. It fails for me on the local network (broken DNS configs at ISP). I had to disable this test in order to be able to run the entire suite.

        Show
        Andrei Savu added a comment - +1 for making this an integration test. It fails for me on the local network (broken DNS configs at ISP). I had to disable this test in order to be able to run the entire suite.
        Hide
        Tom White added a comment -

        DnsUtilTest was moved to be an integration test as a part of WHIRR-150. Increasing the timeout should be addressed here.

        Show
        Tom White added a comment - DnsUtilTest was moved to be an integration test as a part of WHIRR-150 . Increasing the timeout should be addressed here.
        Hide
        Andrei Savu added a comment -

        I've set the DNS resolution timeout to 5 seconds and changed the test. Tom, let me know if it works for you on a slower connection (I'm having some problems running the integration tests).

        Show
        Andrei Savu added a comment - I've set the DNS resolution timeout to 5 seconds and changed the test. Tom, let me know if it works for you on a slower connection (I'm having some problems running the integration tests).
        Hide
        Tom White added a comment -

        It's not easy to reproduce this consistently, but I've made this change locally in the past and it fixed the problem. BTW, the comment is not out of sync with the code, so you might want to update that.

        Tibor - does this change look good to you?

        Show
        Tom White added a comment - It's not easy to reproduce this consistently, but I've made this change locally in the past and it fixed the problem. BTW, the comment is not out of sync with the code, so you might want to update that. Tibor - does this change look good to you?
        Hide
        Andrei Savu added a comment -

        I have fixed the comment.

        Show
        Andrei Savu added a comment - I have fixed the comment.
        Hide
        Tibor Kiss added a comment -

        The fact is that we don't need to identify the InetAddress's delay in case when there is no reverse address. So, we may use a resonable value which also depends on the network characteristics.

        I mean, it's ok this change.

        Show
        Tibor Kiss added a comment - The fact is that we don't need to identify the InetAddress's delay in case when there is no reverse address. So, we may use a resonable value which also depends on the network characteristics. I mean, it's ok this change.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Andrei!

        Show
        Tom White added a comment - I've just committed this. Thanks Andrei!
        Hide
        Andrei Savu added a comment -

        Great! Thanks for reviewing.

        Show
        Andrei Savu added a comment - Great! Thanks for reviewing.

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development