Whirr
  1. Whirr
  2. WHIRR-114

Support + character in version number

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2.0
    • Component/s: core
    • Labels:
      None

      Description

      If a version number contains a + (as it does in CDH) then the URL created for the script location http://whirr.s3.amazonaws.com/VERSION is wrong. It should escape the VERSION string.

        Activity

        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.
        Hide
        Tom White added a comment -

        This should be ready for commit. I've tested it manually too.

        Show
        Tom White added a comment - This should be ready for commit. I've tested it manually too.
        Hide
        Tom White added a comment -

        Here's a fix. I tried leaving the definition of run-url-base in the properties file, but nested properties don't work so I moved that logic into ClusterSpec. (I tried using http://commons.apache.org/configuration/userguide/howto_basicfeatures.html#Customizing_interpolation to create a urlencode lookup but you can't have nested variables, and maven also won't replace $

        {version}

        if it is embedded in another variable).

        Show
        Tom White added a comment - Here's a fix. I tried leaving the definition of run-url-base in the properties file, but nested properties don't work so I moved that logic into ClusterSpec. (I tried using http://commons.apache.org/configuration/userguide/howto_basicfeatures.html#Customizing_interpolation to create a urlencode lookup but you can't have nested variables, and maven also won't replace $ {version} if it is embedded in another variable).

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development