Whirr
  1. Whirr
  2. WHIRR-104

print available services in cli help string

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.2.0
    • Component/s: core
    • Labels:
      None

      Description

      It would be useful to be able to see available services when running cli.

      1. WHIRR-104.patch
        2 kB
        Patrick Hunt
      2. WHIRR-104.patch
        2 kB
        Patrick Hunt
      3. WHIRR-104.patch
        2 kB
        Patrick Hunt

        Activity

        Hide
        Patrick Hunt added a comment -

        updated to fix merge conflict

        Show
        Patrick Hunt added a comment - updated to fix merge conflict
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Patrick Hunt added a comment -

        addressed the formatting.

        I renamed the method to something more appropriate. However I don't think making the method return a sorted set is very good idea - too tight a coupling. it should really just return a collection of service names and let the called decide if it needs it sorted. I did use a treemap though on the caller side ( good idea, cleaned it up a bit).

        Show
        Patrick Hunt added a comment - addressed the formatting. I renamed the method to something more appropriate. However I don't think making the method return a sorted set is very good idea - too tight a coupling. it should really just return a collection of service names and let the called decide if it needs it sorted. I did use a treemap though on the caller side ( good idea, cleaned it up a bit).
        Hide
        Tom White added a comment -

        This looks good. A couple of nits:

        • You could just return a SortedSet in ServiceFactory (Sets.newTreeSet()). I found it slightly odd that list() returned a set - perhaps call it getServiceNames()?
        • Indentation should be two spaces.
        Show
        Tom White added a comment - This looks good. A couple of nits: You could just return a SortedSet in ServiceFactory ( Sets.newTreeSet() ). I found it slightly odd that list() returned a set - perhaps call it getServiceNames()? Indentation should be two spaces.

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development