Whirr
  1. Whirr
  2. WHIRR-102

unknown service NPEs cli, should print the bad service to console

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.2.0
    • Component/s: core
    • Labels:
      None

      Description

      specifying an unknown service results in npe.

      1. WHIRR-102.patch
        16 kB
        Patrick Hunt
      2. WHIRR-102.patch
        1.0 kB
        Patrick Hunt

        Activity

        Hide
        Patrick Hunt added a comment -

        this patch prints the bad service name rather than npe

        Show
        Patrick Hunt added a comment - this patch prints the bad service name rather than npe
        Hide
        Tom White added a comment -

        +1

        • DestroyClusterCommand suffers from the same problem - can we move the code into ClusterSpecCommand?
        • It should be fairly easy to write a unit test for this.
        • Nit: indentation should be two spaces.
        Show
        Tom White added a comment - +1 DestroyClusterCommand suffers from the same problem - can we move the code into ClusterSpecCommand? It should be fairly easy to write a unit test for this. Nit: indentation should be two spaces.
        Hide
        Patrick Hunt added a comment -

        adjusted patch for review comments.

        Show
        Patrick Hunt added a comment - adjusted patch for review comments.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1

          People

          • Assignee:
            Patrick Hunt
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development