Whirr
  1. Whirr
  2. WHIRR-100

Create a binary distribution of Whirr

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2.0
    • Component/s: core
    • Labels:
      None

      Description

      Currently we only release a source distribution and the CLI JAR. It would be convenient to have a binary release that includes the binary JARs, and a whirr script for invoking the CLI JAR.

      1. WHIRR-100.patch
        136 kB
        Tom White
      2. WHIRR-100.patch
        7 kB
        Tom White
      3. WHIRR-100.patch
        5 kB
        Tom White
      4. WHIRR-100.patch
        3 kB
        Tom White
      5. WHIRR-100.patch
        6 kB
        Tom White

        Activity

        Hide
        Tom White added a comment -

        Here's a patch which adds a binary distribution which contains JAR files as well as the source code. It also includes a bin/whirr script to invoke the CLI.

        Before applying the patch run:

        svn mv build-tools/src/assemble.xml build-tools/src/assemble-src.xml
        

        then after the patch has been applied:

        chmod +x bin/whirr
        

        To build, run

        mvn package assembly:assembly
        
        Show
        Tom White added a comment - Here's a patch which adds a binary distribution which contains JAR files as well as the source code. It also includes a bin/whirr script to invoke the CLI. Before applying the patch run: svn mv build-tools/src/assemble.xml build-tools/src/assemble-src.xml then after the patch has been applied: chmod +x bin/whirr To build, run mvn package assembly:assembly
        Hide
        Tom White added a comment -

        Slight change to make the binary distribution name be "whirr-$[version}.tar.gz", which seems to be more common.

        Show
        Tom White added a comment - Slight change to make the binary distribution name be "whirr-$[version}.tar.gz", which seems to be more common.
        Hide
        Patrick Hunt added a comment -

        I tried applying this patch and it seems to work for me.

        However I noticed that the NOTICE file is not mentioning non-apache licensed (non-typeA) lib/jars - for example junit is CPL which is typeb, afaik this has to be detailed in the notice file.

        Show
        Patrick Hunt added a comment - I tried applying this patch and it seems to work for me. However I noticed that the NOTICE file is not mentioning non-apache licensed (non-typeA) lib/jars - for example junit is CPL which is typeb, afaik this has to be detailed in the notice file.
        Hide
        Tom White added a comment -

        Here's a new patch which excludes test JARs (including JUnit). I also went through the JARs in the generated lib directory and checked their licences, I've added a reference to the CDDL-licensed Jersey JAR to the NOTICE file.

        Show
        Tom White added a comment - Here's a new patch which excludes test JARs (including JUnit). I also went through the JARs in the generated lib directory and checked their licences, I've added a reference to the CDDL-licensed Jersey JAR to the NOTICE file.
        Hide
        Patrick Hunt added a comment -

        What about things like slf4j?

        http://www.slf4j.org/license.html

        specifically:
        "The above copyright notice and this permission notice shall be
        included in all copies or substantial portions of the Software."

        Or is it included in the slf4j jars themselves? Is that good enough? (The reason I mention is that I notice solr actually includes this in their notice file https://svn.apache.org/repos/asf/lucene/dev/trunk/solr/NOTICE.txt)

        Show
        Patrick Hunt added a comment - What about things like slf4j? http://www.slf4j.org/license.html specifically: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." Or is it included in the slf4j jars themselves? Is that good enough? (The reason I mention is that I notice solr actually includes this in their notice file https://svn.apache.org/repos/asf/lucene/dev/trunk/solr/NOTICE.txt )
        Hide
        Tom White added a comment -

        Here's a new patch. Many of the JARs include license files, which I believe is sufficient. (Detected with the following.)

        mvn clean package assembly:directory
        for f in target/whirr-0.2.0-incubating-SNAPSHOT/whirr-0.2.0-incubating-SNAPSHOT/lib/*; do
          echo $f;  
          jar tf $f | grep LICENSE;
        done
        

        For those that don't I've included the license in lib alongside the JAR where the license states that this is necessary.

        Show
        Tom White added a comment - Here's a new patch. Many of the JARs include license files, which I believe is sufficient. (Detected with the following.) mvn clean package assembly:directory for f in target/whirr-0.2.0-incubating-SNAPSHOT/whirr-0.2.0-incubating-SNAPSHOT/lib/*; do echo $f; jar tf $f | grep LICENSE; done For those that don't I've included the license in lib alongside the JAR where the license states that this is necessary.
        Hide
        Patrick Hunt added a comment -

        +1, looks good to me and java -jar also works. I reviewed the generated jar file which includes the notice.

        Show
        Patrick Hunt added a comment - +1, looks good to me and java -jar also works. I reviewed the generated jar file which includes the notice.
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development