Wave
  1. Wave
  2. WAVE-313

option to disable "register new user" on web frontend, possibility for admin-user to add manually new users

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1
    • Component/s: Web Client
    • Labels:

      Description

      As today, when you set up a new Wave-in-a-box-Server, everyone who has access to the web Client can create a new user. I think, there are a lot of people who would like to create private Wave-Server, so it would be nice to have an option to disable the "register new users"-site. As a consequence of this, there should also be the possibility to register as admin-user manually new accounts.

        Activity

        Hide
        Ali Lown added a comment -

        Now in trunk.

        Show
        Ali Lown added a comment - Now in trunk.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4235
        -----------------------------------------------------------

        Ship it!

        Committed as r1228584. Thanks for the effort! Please close this review request.

        • Yuri

        On 2012-01-06 19:31:13, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2012-01-06 19:31:13)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039

        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4235 ----------------------------------------------------------- Ship it! Committed as r1228584. Thanks for the effort! Please close this review request. Yuri On 2012-01-06 19:31:13, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2012-01-06 19:31:13) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/
        -----------------------------------------------------------

        (Updated 2012-01-06 19:31:13.500011)

        Review request for wave.

        Changes
        -------

        Implement lennard's suggestions.

        Summary
        -------

        Implements suggestions in WAVE-313:

        • Adds a hideRegistration option to the server config file
        • Removes the auth/registration route when this is the case
        • Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        • Doesn't remove any 'register' links - server 404s when they are clicked.
        • Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.
        https://issues.apache.org/jira/browse/WAVE-313

        Diffs (updated)


        /server-config.xml 1213039
        /server.config.example 1213039
        /src/org/waveprotocol/box/server/CoreSettings.java 1213039
        /src/org/waveprotocol/box/server/ServerMain.java 1213039
        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039
        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039
        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION
        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039
        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing
        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.
        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2012-01-06 19:31:13.500011) Review request for wave. Changes ------- Implement lennard's suggestions. Summary ------- Implements suggestions in WAVE-313 : Adds a hideRegistration option to the server config file Removes the auth/registration route when this is the case Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: Doesn't remove any 'register' links - server 404s when they are clicked. Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs (updated) /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4221
        -----------------------------------------------------------

        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java
        <https://reviews.apache.org/r/3296/#comment9519>

        Rename in this class to registrationDisabled for better readability.

        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java
        <https://reviews.apache.org/r/3296/#comment9520>

        While you are here can you move this line into the else statement where the registration actually completes. It makes the intention much clearer if you'd ask me.

        • Lennard

        On 2012-01-04 15:37:37, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2012-01-04 15:37:37)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039

        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4221 ----------------------------------------------------------- /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java < https://reviews.apache.org/r/3296/#comment9519 > Rename in this class to registrationDisabled for better readability. /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java < https://reviews.apache.org/r/3296/#comment9520 > While you are here can you move this line into the else statement where the registration actually completes. It makes the intention much clearer if you'd ask me. Lennard On 2012-01-04 15:37:37, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2012-01-04 15:37:37) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/
        -----------------------------------------------------------

        (Updated 2012-01-04 15:37:37.798794)

        Review request for wave.

        Changes
        -------

        *) Moved enabled/disabled servlet to the relevant function
        *) Add your suggested LOC to the test. Technically I didn't put the PrintWriter in it was already like that, but now it gets properly tested.

        Summary
        -------

        Implements suggestions in WAVE-313:

        • Adds a hideRegistration option to the server config file
        • Removes the auth/registration route when this is the case
        • Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        • Doesn't remove any 'register' links - server 404s when they are clicked.
        • Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.
        https://issues.apache.org/jira/browse/WAVE-313

        Diffs (updated)


        /server-config.xml 1213039
        /server.config.example 1213039
        /src/org/waveprotocol/box/server/CoreSettings.java 1213039
        /src/org/waveprotocol/box/server/ServerMain.java 1213039
        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039
        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039
        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION
        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039
        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing
        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.
        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2012-01-04 15:37:37.798794) Review request for wave. Changes ------- *) Moved enabled/disabled servlet to the relevant function *) Add your suggested LOC to the test. Technically I didn't put the PrintWriter in it was already like that, but now it gets properly tested. Summary ------- Implements suggestions in WAVE-313 : Adds a hideRegistration option to the server config file Removes the auth/registration route when this is the case Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: Doesn't remove any 'register' links - server 404s when they are clicked. Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs (updated) /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4161
        -----------------------------------------------------------

        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java
        <https://reviews.apache.org/r/3296/#comment9397>

        It seems like the variables (enabledServlet, disabledServlet) are only used in attemptToRegister method. Can we maybe move their declariton/initialization there?

        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java
        <https://reviews.apache.org/r/3296/#comment9396>

        The writer is unused, it seems you intended to use it for mocking on the next line.
        I think we still can do it with something like this:

        when(resp.getWriter()).thenReturn(writer);

        if (disabledRegistration)

        { disabledServlet.doPost(req, resp); }

        else

        { enabledServlet.doPost(req, resp); }

        verify(writer, atLeastOnce()).append(anyString());

        • Yuri

        On 2011-12-23 17:29:42, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2011-12-23 17:29:42)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039

        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4161 ----------------------------------------------------------- /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java < https://reviews.apache.org/r/3296/#comment9397 > It seems like the variables (enabledServlet, disabledServlet) are only used in attemptToRegister method. Can we maybe move their declariton/initialization there? /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java < https://reviews.apache.org/r/3296/#comment9396 > The writer is unused, it seems you intended to use it for mocking on the next line. I think we still can do it with something like this: when(resp.getWriter()).thenReturn(writer); if (disabledRegistration) { disabledServlet.doPost(req, resp); } else { enabledServlet.doPost(req, resp); } verify(writer, atLeastOnce()).append(anyString()); Yuri On 2011-12-23 17:29:42, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-23 17:29:42) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/
        -----------------------------------------------------------

        (Updated 2011-12-23 17:29:42.463299)

        Review request for wave.

        Changes
        -------

        Remove the change I made to build.xml (because I have one non-related test case fail on my machine, so once the related tests pass I disable testing (also speeds up recompiling)).

        Summary
        -------

        Implements suggestions in WAVE-313:

        • Adds a hideRegistration option to the server config file
        • Removes the auth/registration route when this is the case
        • Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        • Doesn't remove any 'register' links - server 404s when they are clicked.
        • Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.
        https://issues.apache.org/jira/browse/WAVE-313

        Diffs (updated)


        /server-config.xml 1213039
        /server.config.example 1213039
        /src/org/waveprotocol/box/server/CoreSettings.java 1213039
        /src/org/waveprotocol/box/server/ServerMain.java 1213039
        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039
        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039
        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION
        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039
        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing
        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.
        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-23 17:29:42.463299) Review request for wave. Changes ------- Remove the change I made to build.xml (because I have one non-related test case fail on my machine, so once the related tests pass I disable testing (also speeds up recompiling)). Summary ------- Implements suggestions in WAVE-313 : Adds a hideRegistration option to the server config file Removes the auth/registration route when this is the case Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: Doesn't remove any 'register' links - server 404s when they are clicked. Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs (updated) /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/
        -----------------------------------------------------------

        (Updated 2011-12-23 17:26:23.110141)

        Review request for wave.

        Changes
        -------

        Implements the suggestions:

        • Remove some random whitespace
        • Renamed to disable_registration
        • Passes signal to UserRegistrationServlet so a page saying "Disabled by administrator" is rendered instead of 404'ing
        • Added a test to UserRegistrationServletTest to ensure user can't be registered by POST'ing to the page with a custom form even when page not rendered.
        • Adjusts a comment correctly

        Rest of the suggestions left for WAVE-314.

        Summary
        -------

        Implements suggestions in WAVE-313:

        • Adds a hideRegistration option to the server config file
        • Removes the auth/registration route when this is the case
        • Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        • Doesn't remove any 'register' links - server 404s when they are clicked.
        • Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.
        https://issues.apache.org/jira/browse/WAVE-313

        Diffs (updated)


        /build.xml 1213039
        /server-config.xml 1213039
        /server.config.example 1213039
        /src/org/waveprotocol/box/server/CoreSettings.java 1213039
        /src/org/waveprotocol/box/server/ServerMain.java 1213039
        /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039
        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039
        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION
        /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039
        /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039

        Diff: https://reviews.apache.org/r/3296/diff

        Testing
        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.
        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-23 17:26:23.110141) Review request for wave. Changes ------- Implements the suggestions: Remove some random whitespace Renamed to disable_registration Passes signal to UserRegistrationServlet so a page saying "Disabled by administrator" is rendered instead of 404'ing Added a test to UserRegistrationServletTest to ensure user can't be registered by POST'ing to the page with a custom form even when page not rendered. Adjusts a comment correctly Rest of the suggestions left for WAVE-314 . Summary ------- Implements suggestions in WAVE-313 : Adds a hideRegistration option to the server config file Removes the auth/registration route when this is the case Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: Doesn't remove any 'register' links - server 404s when they are clicked. Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs (updated) /build.xml 1213039 /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 1213039 /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java 1213039 Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-12-23 04:04:28, Lennard de Rijk wrote:

        > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java, line 2

        > <https://reviews.apache.org/r/3296/diff/1/?file=65765#file65765line2>

        >

        > Should this really still say Google Inc?

        Ali Lown wrote:

        Probably not. What should be there instead? Or just leave out that line?

        I would copy the rest of the code base, but that all seems to still reference Google.

        Yuri will probably know best. I am just getting back into this project.

        On 2011-12-23 04:04:28, Lennard de Rijk wrote:

        > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 98

        > <https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line98>

        >

        > Is there a way to factor welcomebot in to this?

        Ali Lown wrote:

        Not directly into the createUser method (if it lives in RobotAgentUtil.java) without creating circular imports.

        Though, when WAVE-314 is implemented, this would be solved too.

        I would be happy with WAVE-314 solving this.

        • Lennard

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4096
        -----------------------------------------------------------

        On 2011-12-22 23:52:27, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2011-12-22 23:52:27)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-12-23 04:04:28, Lennard de Rijk wrote: > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java, line 2 > < https://reviews.apache.org/r/3296/diff/1/?file=65765#file65765line2 > > > Should this really still say Google Inc? Ali Lown wrote: Probably not. What should be there instead? Or just leave out that line? I would copy the rest of the code base, but that all seems to still reference Google. Yuri will probably know best. I am just getting back into this project. On 2011-12-23 04:04:28, Lennard de Rijk wrote: > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 98 > < https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line98 > > > Is there a way to factor welcomebot in to this? Ali Lown wrote: Not directly into the createUser method (if it lives in RobotAgentUtil.java) without creating circular imports. Though, when WAVE-314 is implemented, this would be solved too. I would be happy with WAVE-314 solving this. Lennard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4096 ----------------------------------------------------------- On 2011-12-22 23:52:27, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-22 23:52:27) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-12-23 04:04:28, Lennard de Rijk wrote:

        > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java, line 2

        > <https://reviews.apache.org/r/3296/diff/1/?file=65765#file65765line2>

        >

        > Should this really still say Google Inc?

        Probably not. What should be there instead? Or just leave out that line?
        I would copy the rest of the code base, but that all seems to still reference Google.

        On 2011-12-23 04:04:28, Lennard de Rijk wrote:

        > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 98

        > <https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line98>

        >

        > Is there a way to factor welcomebot in to this?

        Not directly into the createUser method (if it lives in RobotAgentUtil.java) without creating circular imports.

        Though, when WAVE-314 is implemented, this would be solved too.

        • Ali

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4096
        -----------------------------------------------------------

        On 2011-12-22 23:52:27, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2011-12-22 23:52:27)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-12-23 04:04:28, Lennard de Rijk wrote: > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java, line 2 > < https://reviews.apache.org/r/3296/diff/1/?file=65765#file65765line2 > > > Should this really still say Google Inc? Probably not. What should be there instead? Or just leave out that line? I would copy the rest of the code base, but that all seems to still reference Google. On 2011-12-23 04:04:28, Lennard de Rijk wrote: > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 98 > < https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line98 > > > Is there a way to factor welcomebot in to this? Not directly into the createUser method (if it lives in RobotAgentUtil.java) without creating circular imports. Though, when WAVE-314 is implemented, this would be solved too. Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4096 ----------------------------------------------------------- On 2011-12-22 23:52:27, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-22 23:52:27) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-12-23 06:13:54, Yuri Zelikov wrote:

        > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 98

        > <https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line98>

        >

        > It seems like user registration is an important event, so it might be a good idea to add some mechanism to register a listener on a new user registration - Similar to RobotRegistrar. But it can be done it other patch as well.

        >

        This seems to be tangentially related to the issue this patch is solving, though I agree it would probably be a useful addition to have and would automatically solve the problem with WelcomeBot not working here.
        Created issue WAVE-314 to address this.

        On 2011-12-23 06:13:54, Yuri Zelikov wrote:

        > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 100

        > <https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line100>

        >

        > Would be nice to add a test for this method.

        Agreed. But Given WAVE-314 would centralise this method with the UserRegistrationServlet, I don't think it is worth creating a whole test-case to then remove it once I finish 314.

        • Ali

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4097
        -----------------------------------------------------------

        On 2011-12-22 23:52:27, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2011-12-22 23:52:27)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-12-23 06:13:54, Yuri Zelikov wrote: > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 98 > < https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line98 > > > It seems like user registration is an important event, so it might be a good idea to add some mechanism to register a listener on a new user registration - Similar to RobotRegistrar. But it can be done it other patch as well. > This seems to be tangentially related to the issue this patch is solving, though I agree it would probably be a useful addition to have and would automatically solve the problem with WelcomeBot not working here. Created issue WAVE-314 to address this. On 2011-12-23 06:13:54, Yuri Zelikov wrote: > /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java, line 100 > < https://reviews.apache.org/r/3296/diff/1/?file=65764#file65764line100 > > > Would be nice to add a test for this method. Agreed. But Given WAVE-314 would centralise this method with the UserRegistrationServlet, I don't think it is worth creating a whole test-case to then remove it once I finish 314. Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4097 ----------------------------------------------------------- On 2011-12-22 23:52:27, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-22 23:52:27) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4097
        -----------------------------------------------------------

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
        <https://reviews.apache.org/r/3296/#comment9218>

        It seems like there's white space

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
        <https://reviews.apache.org/r/3296/#comment9219>

        Please remove whitespace

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
        <https://reviews.apache.org/r/3296/#comment9220>

        It seems like user registration is an important event, so it might be a good idea to add some mechanism to register a listener on a new user registration - Similar to RobotRegistrar. But it can be done it other patch as well.

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
        <https://reviews.apache.org/r/3296/#comment9222>

        Would be nice to add a test for this method.

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java
        <https://reviews.apache.org/r/3296/#comment9216>

        Can we adjust the comment for Registration Robot?

        • Yuri

        On 2011-12-22 23:52:27, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2011-12-22 23:52:27)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4097 ----------------------------------------------------------- /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java < https://reviews.apache.org/r/3296/#comment9218 > It seems like there's white space /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java < https://reviews.apache.org/r/3296/#comment9219 > Please remove whitespace /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java < https://reviews.apache.org/r/3296/#comment9220 > It seems like user registration is an important event, so it might be a good idea to add some mechanism to register a listener on a new user registration - Similar to RobotRegistrar. But it can be done it other patch as well. /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java < https://reviews.apache.org/r/3296/#comment9222 > Would be nice to add a test for this method. /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java < https://reviews.apache.org/r/3296/#comment9216 > Can we adjust the comment for Registration Robot? Yuri On 2011-12-22 23:52:27, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-22 23:52:27) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/#review4096
        -----------------------------------------------------------

        /src/org/waveprotocol/box/server/ServerMain.java
        <https://reviews.apache.org/r/3296/#comment9215>

        Can we have the Servlet read the flag (calling it DisableRegistration might be better)? Then the servlet can give a "Registration disabled" message instead of 404'ing.

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java
        <https://reviews.apache.org/r/3296/#comment9213>

        Is there a way to factor welcomebot in to this?

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java
        <https://reviews.apache.org/r/3296/#comment9214>

        Should this really still say Google Inc?

        • Lennard

        On 2011-12-22 23:52:27, Ali Lown wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3296/

        -----------------------------------------------------------

        (Updated 2011-12-22 23:52:27)

        Review request for wave.

        Summary

        -------

        Implements suggestions in WAVE-313:

        - Adds a hideRegistration option to the server config file

        - Removes the auth/registration route when this is the case

        - Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        - Doesn't remove any 'register' links - server 404s when they are clicked.

        - Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.

        https://issues.apache.org/jira/browse/WAVE-313

        Diffs

        -----

        /server-config.xml 1213039

        /server.config.example 1213039

        /src/org/waveprotocol/box/server/CoreSettings.java 1213039

        /src/org/waveprotocol/box/server/ServerMain.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039

        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        Diff: https://reviews.apache.org/r/3296/diff

        Testing

        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.

        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/#review4096 ----------------------------------------------------------- /src/org/waveprotocol/box/server/ServerMain.java < https://reviews.apache.org/r/3296/#comment9215 > Can we have the Servlet read the flag (calling it DisableRegistration might be better)? Then the servlet can give a "Registration disabled" message instead of 404'ing. /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java < https://reviews.apache.org/r/3296/#comment9213 > Is there a way to factor welcomebot in to this? /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java < https://reviews.apache.org/r/3296/#comment9214 > Should this really still say Google Inc? Lennard On 2011-12-22 23:52:27, Ali Lown wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- (Updated 2011-12-22 23:52:27) Review request for wave. Summary ------- Implements suggestions in WAVE-313 : - Adds a hideRegistration option to the server config file - Removes the auth/registration route when this is the case - Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: - Doesn't remove any 'register' links - server 404s when they are clicked. - Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs ----- /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3296/
        -----------------------------------------------------------

        Review request for wave.

        Summary
        -------

        Implements suggestions in WAVE-313:

        • Adds a hideRegistration option to the server config file
        • Removes the auth/registration route when this is the case
        • Adds a RegistrationRobot to let the admin user always create new users

        Know limitations/features:

        • Doesn't remove any 'register' links - server 404s when they are clicked.
        • Manually created users don't get WelcomeBot'd

        This addresses bug WAVE-313.
        https://issues.apache.org/jira/browse/WAVE-313

        Diffs


        /server-config.xml 1213039
        /server.config.example 1213039
        /src/org/waveprotocol/box/server/CoreSettings.java 1213039
        /src/org/waveprotocol/box/server/ServerMain.java 1213039
        /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039
        /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION

        Diff: https://reviews.apache.org/r/3296/diff

        Testing
        -------

        Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true.
        Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid.

        Thanks,

        Ali

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3296/ ----------------------------------------------------------- Review request for wave. Summary ------- Implements suggestions in WAVE-313 : Adds a hideRegistration option to the server config file Removes the auth/registration route when this is the case Adds a RegistrationRobot to let the admin user always create new users Know limitations/features: Doesn't remove any 'register' links - server 404s when they are clicked. Manually created users don't get WelcomeBot'd This addresses bug WAVE-313 . https://issues.apache.org/jira/browse/WAVE-313 Diffs /server-config.xml 1213039 /server.config.example 1213039 /src/org/waveprotocol/box/server/CoreSettings.java 1213039 /src/org/waveprotocol/box/server/ServerMain.java 1213039 /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java 1213039 /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java PRE-CREATION Diff: https://reviews.apache.org/r/3296/diff Testing ------- Compiled + run. Tried to access auth/register with hideRegistration=false and hideRegistration=true. Logged in as the admin user and tried to create new accounts with the RegistrationRobot - then logged into new accounts to check valid. Thanks, Ali

          People

          • Assignee:
            Ali Lown
            Reporter:
            JGB
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development