Wave
  1. Wave
  2. WAVE-311

Implement full text search for Wiab

    Details

    • Type: New Feature New Feature
    • Status: In Progress
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Server, Web Client
    • Labels:
      None

      Description

      Implement full text search functionality for WIAB similar to Google Wave.

        Activity

        Yuri Zelikov created issue -
        Hide
        Frank Ren added a comment - - edited

        I've created full text search with solr. http://wiki.apache.org/solr/SolrQuerySyntax

        Here is the changeset, https://github.com/renfeng/wave/commit/b6d76d829ff047f6d042625c59bb906999b8e956

        Set search_type = solr, and start wave.

        Tested against Solr 4.5.1, http://www.apache.org/dyn/closer.cgi/lucene/solr/4.5.1

        All you need with solr is to follow the guide, Getting Started, http://lucene.apache.org/solr/4_5_1/tutorial.html

        Show
        Frank Ren added a comment - - edited I've created full text search with solr. http://wiki.apache.org/solr/SolrQuerySyntax Here is the changeset, https://github.com/renfeng/wave/commit/b6d76d829ff047f6d042625c59bb906999b8e956 Set search_type = solr, and start wave. Tested against Solr 4.5.1, http://www.apache.org/dyn/closer.cgi/lucene/solr/4.5.1 All you need with solr is to follow the guide, Getting Started, http://lucene.apache.org/solr/4_5_1/tutorial.html
        Hide
        Yuri Zelikov added a comment -

        Hi Frank
        Thanks!
        Looks nice! I guess we should also add an embedded Solr into WIAB so it will have everything in one place. Actually I already did it but never implemented the actual search. I ll try to combine my changes with your and make a patch out of it.
        The ultimate goal is to add user data into the search index so we will not have to read the wavelets at all while searching but only for actual wave loading.

        Show
        Yuri Zelikov added a comment - Hi Frank Thanks! Looks nice! I guess we should also add an embedded Solr into WIAB so it will have everything in one place. Actually I already did it but never implemented the actual search. I ll try to combine my changes with your and make a patch out of it. The ultimate goal is to add user data into the search index so we will not have to read the wavelets at all while searching but only for actual wave loading.
        Hide
        Frank Ren added a comment -

        I made a few patches. Please get updated. https://github.com/renfeng/wave

        Show
        Frank Ren added a comment - I made a few patches. Please get updated. https://github.com/renfeng/wave
        Hide
        Ali Lown added a comment -

        @Frank/Yuri,
        Do you think we could get this submitted for review, so we can try to get it in for the release?

        Show
        Ali Lown added a comment - @Frank/Yuri, Do you think we could get this submitted for review, so we can try to get it in for the release?
        Hide
        Frank Ren added a comment -

        I'm ready for it. Tell me how I can help?

        Show
        Frank Ren added a comment - I'm ready for it. Tell me how I can help?
        Hide
        Ali Lown added a comment -

        As noted here: https://incubator.apache.org/wave/get-involved.html

        Please tidy this into a single patch (and if necessary rebase to master), then submit to review-board, adding 'wave' as the group.

        Show
        Ali Lown added a comment - As noted here: https://incubator.apache.org/wave/get-involved.html Please tidy this into a single patch (and if necessary rebase to master), then submit to review-board, adding 'wave' as the group.
        Hide
        Frank Ren added a comment -

        I have two questions here.

        • Where to get the master? Is it here,
          https://github.com/apache/wave/commits/wave-0.4-release?
        • In the New Review Request form, I was asked to submit a diff file and
          a parent diff file. I don't know how to make a patch out of a set of git
          commits. I'm going to Google it. Meanwhile, do you happen to have some
          guide for me?

        Are you available on Google Hangout?

        Show
        Frank Ren added a comment - I have two questions here. Where to get the master? Is it here, https://github.com/apache/wave/commits/wave-0.4-release? In the New Review Request form, I was asked to submit a diff file and a parent diff file. I don't know how to make a patch out of a set of git commits. I'm going to Google it. Meanwhile, do you happen to have some guide for me? Are you available on Google Hangout?
        Hide
        Ali Lown added a comment -

        Please use the mirrors listed on https://incubator.apache.org/wave/source-code.html
        You can create patches using 'git format-patch'. Parent diff is only needed for some special cases, you won't need to use it for this.

        I am on Hangouts, but please come find me at #wiab on freenode instead.

        Show
        Ali Lown added a comment - Please use the mirrors listed on https://incubator.apache.org/wave/source-code.html You can create patches using 'git format-patch'. Parent diff is only needed for some special cases, you won't need to use it for this. I am on Hangouts, but please come find me at #wiab on freenode instead.
        Hide
        Frank Ren added a comment -

        I found this, http://grails.org/Creating+Patches+From+Git

        The remote repositories for my git clone are as following.
        renfeng@dreadnought ~/Documents/git/wave $ git remote -v
        github https://github.com/apache/wave (fetch)
        github https://github.com/apache/wave (push)
        origin git://git.apache.org/wave.git (fetch)
        origin git://git.apache.org/wave.git (push)
        renfeng https://renfeng@github.com/renfeng/wave (fetch)
        renfeng https://renfeng@github.com/renfeng/wave (push)

        solr-bot is my branch. I changed trunk as well.
        renfeng@dreadnought ~/Documents/git/wave $ git branch
        solr-bot

        • trunk

        Shall I do the following?
        git checkout wave-0.4-release
        git pull apache
        git checkout trunk
        git rebase wave-0.4-release

        Show
        Frank Ren added a comment - I found this, http://grails.org/Creating+Patches+From+Git The remote repositories for my git clone are as following. renfeng@dreadnought ~/Documents/git/wave $ git remote -v github https://github.com/apache/wave (fetch) github https://github.com/apache/wave (push) origin git://git.apache.org/wave.git (fetch) origin git://git.apache.org/wave.git (push) renfeng https://renfeng@github.com/renfeng/wave (fetch) renfeng https://renfeng@github.com/renfeng/wave (push) solr-bot is my branch. I changed trunk as well. renfeng@dreadnought ~/Documents/git/wave $ git branch solr-bot trunk Shall I do the following? git checkout wave-0.4-release git pull apache git checkout trunk git rebase wave-0.4-release
        Hide
        Frank Ren added a comment -

        Is it an IRC channel, #wiab on freenode?

        Show
        Frank Ren added a comment - Is it an IRC channel, #wiab on freenode?
        Hide
        Yuri Zelikov added a comment -

        I think parent diff is optional.

        Show
        Yuri Zelikov added a comment - I think parent diff is optional.
        Hide
        Frank Ren added a comment -

        It gave me an error when I tried to pull from git://git.apache.org/wave.git
        renfeng@dreadnought ~/Documents/git/wave $ git pull
        fatal: The remote end hung up unexpectedly

        Anyway, the new git repository works fine.
        https://git-wip-us.apache.org/repos/asf/incubator-wave.git

        Show
        Frank Ren added a comment - It gave me an error when I tried to pull from git://git.apache.org/wave.git renfeng@dreadnought ~/Documents/git/wave $ git pull fatal: The remote end hung up unexpectedly Anyway, the new git repository works fine. https://git-wip-us.apache.org/repos/asf/incubator-wave.git
        Hide
        Frank Ren added a comment -

        Thank you~

        Show
        Frank Ren added a comment - Thank you~
        Hide
        Frank Ren added a comment -

        By following the guide, http://grails.org/Creating+Patches+From+Git, I have
        15 patch files. It requires to upload them one at a time. Besides, reviewer
        is also mandatory, which doesn't make sense to me - before I can submit, I
        need reviewers. How can I get reviewers if I don't submit?

        Show
        Frank Ren added a comment - By following the guide, http://grails.org/Creating+Patches+From+Git , I have 15 patch files. It requires to upload them one at a time. Besides, reviewer is also mandatory, which doesn't make sense to me - before I can submit, I need reviewers. How can I get reviewers if I don't submit?
        Hide
        Yuri Zelikov added a comment -

        I guess you ll need to "squash" the commits into one big commit.
        Just look for the "wave-dev" group in reviewers, you can also add some committers by name, like: yurize, alown, vjrj,

        Show
        Yuri Zelikov added a comment - I guess you ll need to "squash" the commits into one big commit. Just look for the "wave-dev" group in reviewers, you can also add some committers by name, like: yurize, alown, vjrj,
        Hide
        Frank Ren added a comment -

        Thanks for the list of reviewer names. My problem is that I can't edit the
        reviewers (with Chrome and Firefox). It's not clickable. There is not input
        or drop box.

        Show
        Frank Ren added a comment - Thanks for the list of reviewer names. My problem is that I can't edit the reviewers (with Chrome and Firefox). It's not clickable. There is not input or drop box.
        Hide
        Yuri Zelikov added a comment -

        What happens when you click with mouse on the pen icon near the "Groups"?

        Show
        Yuri Zelikov added a comment - What happens when you click with mouse on the pen icon near the "Groups"?
        Ali Lown made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Assignee Yuri Zelikov [ yurize ] Ali Lown [ alown ]
        Ali Lown made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Ali Lown made changes -
        Assignee Ali Lown [ alown ]
        Yuri Zelikov made changes -
        Assignee Yuri Zelikov [ yurize ]
        Hide
        Yuri Zelikov added a comment -

        Hi Frank
        Will it be OK with you if I ll try to address the remaining issues on your patch?

        Show
        Yuri Zelikov added a comment - Hi Frank Will it be OK with you if I ll try to address the remaining issues on your patch?
        Hide
        Frank Ren added a comment -

        Hi Yuri

        Sorry for the delay. I just came back from a long holiday vacation. I'll
        take some time and see what the problem was.

        As I said, I use wave day to day in my office. I'm more of a user than a
        developer to wave. It's not a toy for me - I want it stable. So, I'm going
        to ask how will the new search feature be tested? Thanks.

        Regards,
        Frank

        Show
        Frank Ren added a comment - Hi Yuri Sorry for the delay. I just came back from a long holiday vacation. I'll take some time and see what the problem was. As I said, I use wave day to day in my office. I'm more of a user than a developer to wave. It's not a toy for me - I want it stable. So, I'm going to ask how will the new search feature be tested? Thanks. Regards, Frank
        Hide
        Frank Ren added a comment -

        b.t.w. You can find the bugs or ideas for enhancement here,
        https://github.com/renfeng/wave/issues

        This one is about the search feature,
        https://github.com/renfeng/wave/issues/7

        I'm not ready to fix that before I understand better how the web ui works.

        Show
        Frank Ren added a comment - b.t.w. You can find the bugs or ideas for enhancement here, https://github.com/renfeng/wave/issues This one is about the search feature, https://github.com/renfeng/wave/issues/7 I'm not ready to fix that before I understand better how the web ui works.
        Yuri Zelikov made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        ASF subversion and git services added a comment -

        Commit f0674d28c6432aa30089ffd59dcf42309a63dc92 in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=f0674d2 ]

        WAVE-311 Refactors some search related code.

        Show
        ASF subversion and git services added a comment - Commit f0674d28c6432aa30089ffd59dcf42309a63dc92 in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=f0674d2 ] WAVE-311 Refactors some search related code.
        Hide
        ASF subversion and git services added a comment -

        Commit 95b227089ae3bf379c155452d0ba909932c4b0a1 in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=95b2270 ]

        WAVE-311 Refactors some more, ensures Solr search result include user data wavelet.

        Show
        ASF subversion and git services added a comment - Commit 95b227089ae3bf379c155452d0ba909932c4b0a1 in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=95b2270 ] WAVE-311 Refactors some more, ensures Solr search result include user data wavelet.
        Hide
        ASF subversion and git services added a comment -

        Commit 8671848b151f4c7914f109ab177f18bd8ddaf5fa in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=8671848 ]

        WAVE-311 Updates Snippets.collatetextForOps to accept custom function to modify the result on new lines.

        Show
        ASF subversion and git services added a comment - Commit 8671848b151f4c7914f109ab177f18bd8ddaf5fa in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=8671848 ] WAVE-311 Updates Snippets.collatetextForOps to accept custom function to modify the result on new lines.
        Hide
        ASF subversion and git services added a comment -

        Commit 35ec03b96b2ff30f4f94008a008b66dcaf11eb65 in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=35ec03b ]

        WAVE-311 Refactored title construction by adding getWavelet method to WaveMap and moving the code into base class.

        Show
        ASF subversion and git services added a comment - Commit 35ec03b96b2ff30f4f94008a008b66dcaf11eb65 in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=35ec03b ] WAVE-311 Refactored title construction by adding getWavelet method to WaveMap and moving the code into base class.
        Hide
        ASF subversion and git services added a comment -

        Commit d83da50210d9e193c66e7bba46e5b4b1fb9b4e7b in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov
        [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=d83da50 ]

        WAVE-311 Refactors the Solr search related classes some more.

        Show
        ASF subversion and git services added a comment - Commit d83da50210d9e193c66e7bba46e5b4b1fb9b4e7b in incubator-wave's branch refs/heads/fulltextsearch from Yuri Zelikov [ https://git-wip-us.apache.org/repos/asf?p=incubator-wave.git;h=d83da50 ] WAVE-311 Refactors the Solr search related classes some more.

          People

          • Assignee:
            Yuri Zelikov
            Reporter:
            Yuri Zelikov
          • Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development