Wave
  1. Wave
  2. WAVE-305

Cannot open a new wave just after creation - No conversations in this wave.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Web Client
    • Labels:
      None

      Description

      Steps to reproduce:
      Cannot be reproduced reliably. Doesn't happen in my local dev environment. Happens in waveinabox.net, usually when the server is under load.
      1. Create a new wave. Enter some text.
      2. Click on the wave digest in order to reload the wave.
      Expected: The wave is reloaded and displayed with all content.
      Actual: Empty panel displayed with message: "No conversations in this wave"

      This is the log that i think is related to the issue:

      2011-11-25 09:48:28.775:DBUG:oejs.AsyncHttpConnection:async request (null null)@2782586 org.eclipse.jetty.server.Request@2a757a
      Nov 25, 2011 9:48:28 AM org.waveprotocol.box.server.frontend.WaveViewSubscription submitRequest
      INFO: Submit oustandinding on channel ch9
      Nov 25, 2011 9:48:28 AM org.waveprotocol.box.server.waveserver.WaveServerImpl submitDelta
      INFO: Submit to [WaveletName waveinabox.net/w+lAjXzMOY0eA/waveinabox.net/user+julianhanhart@waveinabox.net] by julianhanhart@waveinabox.net @ 0 with 1 ops
      Nov 25, 2011 9:48:28 AM org.waveprotocol.box.server.waveserver.LocalWaveletContainerImpl transformAndApplyLocalDelta
      INFO: Duplicate delta TransformedWaveletDelta(julianhanhart@waveinabox.net, 1:jDFIgvDgRupnm6BkVyXhy88rza8=, 1322214480147 -> 1 ops: [add participant julianhanhart@waveinabox.net by julianhanhart@waveinabox.net at Fri Nov 25 09:48:00 UTC 2011 version 1:jDFIgvDgRupnm6BkVyXhy88rza8=]) for wavelet [WaveletName waveinabox.net/w+lAjXzMOY0eA/waveinabox.net/user+julianhanhart@waveinabox.net]
      Nov 25, 2011 9:48:28 AM org.waveprotocol.box.server.waveserver.WaveServerImpl submitDelta
      INFO: Submit result for [WaveletName waveinabox.net/w+lAjXzMOY0eA/waveinabox.net/user+julianhanhart@waveinabox.net] by julianhanhart@waveinabox.net applied 1 ops at v: 0 t: 1322214480147
      Nov 25, 2011 9:48:28 AM org.waveprotocol.box.server.frontend.WaveViewSubscription submitResponse
      INFO: Submit resolved on channel ch9

      Seems like the first delta that adds the participant to the new (empty) wavelet is somehow duplicated and then on loading the participant is not recognized as author and doesn't have the access to this wavelet.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-02 13:17:48, Andrew Kaplanov wrote:

        > LGTM.

        Committed as r1310688

        • Yuri

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4572/#review6618
        -----------------------------------------------------------

        On 2012-03-30 10:30:41, Yuri Zelikov wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4572/

        -----------------------------------------------------------

        (Updated 2012-03-30 10:30:41)

        Review request for wave, Michael MacFadden and Andrew Kaplanov.

        Summary

        -------

        Handles the second part of issue WAVE-305 - cannot open new wave.

        This addresses bug WAVE-305.

        https://issues.apache.org/jira/browse/WAVE-305

        Diffs

        -----

        src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 0fb9190

        Diff: https://reviews.apache.org/r/4572/diff

        Testing

        -------

        Thanks,

        Yuri

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-02 13:17:48, Andrew Kaplanov wrote: > LGTM. Committed as r1310688 Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4572/#review6618 ----------------------------------------------------------- On 2012-03-30 10:30:41, Yuri Zelikov wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4572/ ----------------------------------------------------------- (Updated 2012-03-30 10:30:41) Review request for wave, Michael MacFadden and Andrew Kaplanov. Summary ------- Handles the second part of issue WAVE-305 - cannot open new wave. This addresses bug WAVE-305 . https://issues.apache.org/jira/browse/WAVE-305 Diffs ----- src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 0fb9190 Diff: https://reviews.apache.org/r/4572/diff Testing ------- Thanks, Yuri
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4572/#review6618
        -----------------------------------------------------------

        LGTM.

        • Andrew

        On 2012-03-30 10:30:41, Yuri Zelikov wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4572/

        -----------------------------------------------------------

        (Updated 2012-03-30 10:30:41)

        Review request for wave, Michael MacFadden and Andrew Kaplanov.

        Summary

        -------

        Handles the second part of issue WAVE-305 - cannot open new wave.

        This addresses bug WAVE-305.

        https://issues.apache.org/jira/browse/WAVE-305

        Diffs

        -----

        src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 0fb9190

        Diff: https://reviews.apache.org/r/4572/diff

        Testing

        -------

        Thanks,

        Yuri

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4572/#review6618 ----------------------------------------------------------- LGTM. Andrew On 2012-03-30 10:30:41, Yuri Zelikov wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4572/ ----------------------------------------------------------- (Updated 2012-03-30 10:30:41) Review request for wave, Michael MacFadden and Andrew Kaplanov. Summary ------- Handles the second part of issue WAVE-305 - cannot open new wave. This addresses bug WAVE-305 . https://issues.apache.org/jira/browse/WAVE-305 Diffs ----- src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 0fb9190 Diff: https://reviews.apache.org/r/4572/diff Testing ------- Thanks, Yuri
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4572/
        -----------------------------------------------------------

        Review request for wave, Michael MacFadden and Andrew Kaplanov.

        Summary
        -------

        Handles the second part of issue WAVE-305 - cannot open new wave.

        This addresses bug WAVE-305.
        https://issues.apache.org/jira/browse/WAVE-305

        Diffs


        src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 0fb9190

        Diff: https://reviews.apache.org/r/4572/diff

        Testing
        -------

        Thanks,

        Yuri

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4572/ ----------------------------------------------------------- Review request for wave, Michael MacFadden and Andrew Kaplanov. Summary ------- Handles the second part of issue WAVE-305 - cannot open new wave. This addresses bug WAVE-305 . https://issues.apache.org/jira/browse/WAVE-305 Diffs src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 0fb9190 Diff: https://reviews.apache.org/r/4572/diff Testing ------- Thanks, Yuri
        Hide
        Yuri Zelikov added a comment -

        The issue is with the subscriber on the wavelet commits/updates being removed after throwing exception. We handled the commits but there's also updates case. So the patch (actually work around) is not complete.

        Show
        Yuri Zelikov added a comment - The issue is with the subscriber on the wavelet commits/updates being removed after throwing exception. We handled the commits but there's also updates case. So the patch (actually work around) is not complete.
        Hide
        Yuri Zelikov added a comment -

        Yes, I updated it with this patch and yes, I am getting it too atm. Maybe there is also deadlock issue as well.
        Thanks for reporting I ll investigate it to check if the bug still happens or it's another bug or waveinabox.net not updated correctly.

        Show
        Yuri Zelikov added a comment - Yes, I updated it with this patch and yes, I am getting it too atm. Maybe there is also deadlock issue as well. Thanks for reporting I ll investigate it to check if the bug still happens or it's another bug or waveinabox.net not updated correctly.
        Hide
        Zachary Yaro added a comment -

        Has waveinabox.net been updated since the fix? I got the “No conversations in this wave.” error on a wave I just created.

        Show
        Zachary Yaro added a comment - Has waveinabox.net been updated since the fix? I got the “No conversations in this wave.” error on a wave I just created.
        Hide
        Vicente J. Ruiz Jurado added a comment -

        Good job guys... (By the way, I only had time to test the "ClientFrontendImpl" suggestion and was not fixing the issue).

        Show
        Vicente J. Ruiz Jurado added a comment - Good job guys... (By the way, I only had time to test the "ClientFrontendImpl" suggestion and was not fixing the issue).
        Hide
        Yuri Zelikov added a comment -

        Committed as revision 1301403

        Show
        Yuri Zelikov added a comment - Committed as revision 1301403
        Hide
        Yuri Zelikov added a comment -

        Update. I talked with Andrew today and he says that found the source of the issue - WaveletNotificationDispatcher line 129. It means that if any exception was allowed to leak from the subscriber - it is removed... A quick workaround would be just to comment the line where subscriber is removed.

        Show
        Yuri Zelikov added a comment - Update. I talked with Andrew today and he says that found the source of the issue - WaveletNotificationDispatcher line 129. It means that if any exception was allowed to leak from the subscriber - it is removed... A quick workaround would be just to comment the line where subscriber is removed.
        Hide
        Vicente J. Ruiz Jurado added a comment -

        I'll try it ASAP... thanks...

        Show
        Vicente J. Ruiz Jurado added a comment - I'll try it ASAP... thanks...
        Hide
        Yuri Zelikov added a comment -

        It seems like there is a deadlock in the ClientFrontendImpl. The current suspect is synchronization at line 120 " synchronized (userManager) {}". You can try to remove this synchronization and see if it helps.

        Show
        Yuri Zelikov added a comment - It seems like there is a deadlock in the ClientFrontendImpl. The current suspect is synchronization at line 120 " synchronized (userManager) {}". You can try to remove this synchronization and see if it helps.
        Hide
        Vicente J. Ruiz Jurado added a comment -

        We create waves via an agent, and also we get a "No conversation" error from time to time (solved only we a restart).

        Can be the source of the problem some not synchronized object, or some duplicate objects accessing the delta files?

        Show
        Vicente J. Ruiz Jurado added a comment - We create waves via an agent, and also we get a "No conversation" error from time to time (solved only we a restart). Can be the source of the problem some not synchronized object, or some duplicate objects accessing the delta files?
        Hide
        Vytenis added a comment -

        Not sure that I understand where the problem is, but I think that any workaround would be great as this would be one step closer to making WIAB usable.

        Show
        Vytenis added a comment - Not sure that I understand where the problem is, but I think that any workaround would be great as this would be one step closer to making WIAB usable.
        Hide
        Yuri Zelikov added a comment -

        I started to think about some workaround - like I am pretty sure that if the new wave is created via Robot/Data API - it can be viewed without problems. So, maybe we can add a new Ajax service - similar to searching that will create a new wave on the server side and will just return the wave id that will be opened on the client.

        Show
        Yuri Zelikov added a comment - I started to think about some workaround - like I am pretty sure that if the new wave is created via Robot/Data API - it can be viewed without problems. So, maybe we can add a new Ajax service - similar to searching that will create a new wave on the server side and will just return the wave id that will be opened on the client.
        Hide
        Maze added a comment -

        Same problem here. After a server restart, the new waves become accessible again.

        It doesn't seem to be related to server load. Instead it happens after some time.

        Show
        Maze added a comment - Same problem here. After a server restart, the new waves become accessible again. It doesn't seem to be related to server load. Instead it happens after some time.
        Hide
        Vytenis added a comment - - edited

        Most of the time it happens as follows: once problem occures (at first everything works fine just after server restart), any new wave can not be reopened once is closed. Old waves keep working fine.
        The interesting thing here is that if server is restarted, those new waves become perfectly accessible.

        I am not sure, but once this problem occures only after some time from the server restart, it might be related to https://issues.apache.org/jira/browse/WAVE-315

        I have experienced this problem locally - not on demo servers. No big load was required in order to reproduce it.

        Show
        Vytenis added a comment - - edited Most of the time it happens as follows: once problem occures (at first everything works fine just after server restart), any new wave can not be reopened once is closed. Old waves keep working fine. The interesting thing here is that if server is restarted, those new waves become perfectly accessible. I am not sure, but once this problem occures only after some time from the server restart, it might be related to https://issues.apache.org/jira/browse/WAVE-315 I have experienced this problem locally - not on demo servers. No big load was required in order to reproduce it.

          People

          • Assignee:
            Yuri Zelikov
            Reporter:
            Yuri Zelikov
          • Votes:
            6 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development