Wave
  1. Wave
  2. WAVE-298

Wave doesn't compile: error: no suitable method found for thenReturn(StringTokenizer)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1
    • Fix Version/s: None
    • Component/s: Server
    • Labels:
      None
    • Environment:
      Tested on Debian/unstable with Java 6 and Java 7, and on Ubuntu 11.10.

      Description

      $ ant
      [...]
      compile-tests:
      [javac] Compiling 380 source files to /home/tal/src/wave/build/test
      [javac] /home/tal/src/wave/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java:99: error: no suitable method found for thenReturn(StringTokenizer)
      [javac] when(req.getHeaderNames()).thenReturn(new StringTokenizer("Authorization"));
      [javac] ^
      [javac] method OngoingStubbing.thenReturn(Enumeration<String>) is not applicable
      [javac] (actual argument StringTokenizer cannot be converted to Enumeration<String> by method invocation conversion)
      [javac] method OngoingStubbing.thenReturn(Enumeration<String>,Enumeration<String>...) is not applicable
      [javac] (actual argument StringTokenizer cannot be converted to Enumeration<String> by method invocation conversion)
      [javac] /home/tal/src/wave/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java:112: error: no suitable method found for thenReturn(StringTokenizer)
      [javac] when(req.getHeaders("Authorization")).thenReturn(generateOAuthHeader(ROBOT.getAddress()));

      There are no Sub-Tasks for this issue.

        Activity

        Thomas Leonard created issue -
        Hide
        Jochen Bedersdorfer added a comment -

        Same issue on Snow Leopard using HEAD of the git mirror

        Show
        Jochen Bedersdorfer added a comment - Same issue on Snow Leopard using HEAD of the git mirror
        Hide
        Jochen Bedersdorfer added a comment -

        work-around:

        rm test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java
        rm test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java

        Show
        Jochen Bedersdorfer added a comment - work-around: rm test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java rm test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
        Yuri Zelikov made changes -
        Field Original Value New Value
        Assignee Yuri Zelikov [ yurize ]
        Hide
        Antonio Bello added a comment -

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        • convert StringTokenizer to Enumeration<String> in ActiveApiServletTest
        • replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest
        Show
        Antonio Bello added a comment - This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: convert StringTokenizer to Enumeration<String> in ActiveApiServletTest replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest
        Antonio Bello made changes -
        Attachment patch-wave-298.txt [ 12505138 ]
        Hide
        Yuri Zelikov added a comment -

        Great, thanks!
        Would you like to officially submit it as a patch at https://reviews.apache.org?

        Show
        Yuri Zelikov added a comment - Great, thanks! Would you like to officially submit it as a patch at https://reviews.apache.org?
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/
        -----------------------------------------------------------

        Review request for wave.

        Summary
        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        • convert StringTokenizer to Enumeration<String> in ActiveApiServletTest
        • replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.
        https://issues.apache.org/jira/browse/WAVE-298

        Diffs


        Diff: https://reviews.apache.org/r/2932/diff

        Testing
        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: convert StringTokenizer to Enumeration<String> in ActiveApiServletTest replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/
        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15.596246)

        Review request for wave.

        Summary
        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        • convert StringTokenizer to Enumeration<String> in ActiveApiServletTest
        • replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.
        https://issues.apache.org/jira/browse/WAVE-298

        Diffs (updated)


        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126
        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing
        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15.596246) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: convert StringTokenizer to Enumeration<String> in ActiveApiServletTest replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs (updated) /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3515
        -----------------------------------------------------------

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
        <https://reviews.apache.org/r/2932/#comment7852>

        The line is too long - longer than 100 chars which is the standard for WIAB.

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
        <https://reviews.apache.org/r/2932/#comment7859>

        Line is too long.

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
        <https://reviews.apache.org/r/2932/#comment7856>

        Seems like the <code></code> tags here are not needed,

        {@link}

        already formats it.

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
        <https://reviews.apache.org/r/2932/#comment7854>

        No need to specify that methods solve issue.

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
        <https://reviews.apache.org/r/2932/#comment7855>

        Probably it would be better just to remove @param and @return since they add no details.

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java
        <https://reviews.apache.org/r/2932/#comment7849>

        How about returning the Collections.EmptyMap() here?
        I mean:
        Map<String, String[]> emptyMap = Collections.emptyMap();
        when(req.getParameterMap()).thenReturn(emptyMap);

        • Yuri

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3515 ----------------------------------------------------------- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java < https://reviews.apache.org/r/2932/#comment7852 > The line is too long - longer than 100 chars which is the standard for WIAB. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java < https://reviews.apache.org/r/2932/#comment7859 > Line is too long. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java < https://reviews.apache.org/r/2932/#comment7856 > Seems like the <code></code> tags here are not needed, {@link} already formats it. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java < https://reviews.apache.org/r/2932/#comment7854 > No need to specify that methods solve issue. /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java < https://reviews.apache.org/r/2932/#comment7855 > Probably it would be better just to remove @param and @return since they add no details. /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java < https://reviews.apache.org/r/2932/#comment7849 > How about returning the Collections.EmptyMap() here? I mean: Map<String, String[]> emptyMap = Collections.emptyMap(); when(req.getParameterMap()).thenReturn(emptyMap); Yuri On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        Ship it!

        Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.
        I will address the comments by myself and commit if it's OK with you.

        • Yuri

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- Ship it! Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. I will address the comments by myself and commit if it's OK with you. Yuri On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-26 10:12:55, Yuri Zelikov wrote:

        > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.

        > I will address the comments by myself and commit if it's OK with you.

        Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.
        Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.

        Antonio

        • Antonio

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-26 10:12:55, Yuri Zelikov wrote: > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. > I will address the comments by myself and commit if it's OK with you. Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it. Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture. Antonio Antonio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-26 10:12:55, Yuri Zelikov wrote:

        > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.

        > I will address the comments by myself and commit if it's OK with you.

        Antonio Bello wrote:

        Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.

        Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.

        Antonio

        This is great, thanks!

        • Yuri

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-26 10:12:55, Yuri Zelikov wrote: > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. > I will address the comments by myself and commit if it's OK with you. Antonio Bello wrote: Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it. Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture. Antonio This is great, thanks! Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-26 10:12:55, Yuri Zelikov wrote:

        > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.

        > I will address the comments by myself and commit if it's OK with you.

        Antonio Bello wrote:

        Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.

        Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.

        Antonio

        Yuri Zelikov wrote:

        This is great, thanks!

        My pleasure
        I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one

        • Antonio

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-26 10:12:55, Yuri Zelikov wrote: > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. > I will address the comments by myself and commit if it's OK with you. Antonio Bello wrote: Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it. Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture. Antonio Yuri Zelikov wrote: This is great, thanks! My pleasure I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one Antonio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-26 10:12:55, Yuri Zelikov wrote:

        > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.

        > I will address the comments by myself and commit if it's OK with you.

        Antonio Bello wrote:

        Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.

        Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.

        Antonio

        Yuri Zelikov wrote:

        This is great, thanks!

        Antonio Bello wrote:

        My pleasure

        I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one

        For getting the latest code you can use either the SVN repository or the Git mirror
        SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/
        Git mirror: git://git.apache.org/wave.git
        If you feel ready to submit a patch - then just use this Review Board for this.

        • Yuri

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-26 10:12:55, Yuri Zelikov wrote: > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. > I will address the comments by myself and commit if it's OK with you. Antonio Bello wrote: Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it. Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture. Antonio Yuri Zelikov wrote: This is great, thanks! Antonio Bello wrote: My pleasure I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one For getting the latest code you can use either the SVN repository or the Git mirror SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/ Git mirror: git://git.apache.org/wave.git If you feel ready to submit a patch - then just use this Review Board for this. Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Yuri Zelikov made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-26 10:12:55, Yuri Zelikov wrote:

        > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.

        > I will address the comments by myself and commit if it's OK with you.

        Antonio Bello wrote:

        Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.

        Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.

        Antonio

        Yuri Zelikov wrote:

        This is great, thanks!

        Antonio Bello wrote:

        My pleasure

        I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one

        Yuri Zelikov wrote:

        For getting the latest code you can use either the SVN repository or the Git mirror

        SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/

        Git mirror: git://git.apache.org/wave.git

        If you feel ready to submit a patch - then just use this Review Board for this.

        Can you please close this review request?

        • Yuri

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-26 10:12:55, Yuri Zelikov wrote: > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. > I will address the comments by myself and commit if it's OK with you. Antonio Bello wrote: Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it. Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture. Antonio Yuri Zelikov wrote: This is great, thanks! Antonio Bello wrote: My pleasure I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one Yuri Zelikov wrote: For getting the latest code you can use either the SVN repository or the Git mirror SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/ Git mirror: git://git.apache.org/wave.git If you feel ready to submit a patch - then just use this Review Board for this. Can you please close this review request? Yuri ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-26 10:12:55, Yuri Zelikov wrote:

        > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM.

        > I will address the comments by myself and commit if it's OK with you.

        Antonio Bello wrote:

        Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it.

        Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture.

        Antonio

        Yuri Zelikov wrote:

        This is great, thanks!

        Antonio Bello wrote:

        My pleasure

        I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one

        Yuri Zelikov wrote:

        For getting the latest code you can use either the SVN repository or the Git mirror

        SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/

        Git mirror: git://git.apache.org/wave.git

        If you feel ready to submit a patch - then just use this Review Board for this.

        Yuri Zelikov wrote:

        Can you please close this review request?

        Ditto. Please close this review request?

        • Ali

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2932/#review3517
        -----------------------------------------------------------

        On 2011-11-25 18:23:15, Antonio Bello wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2932/

        -----------------------------------------------------------

        (Updated 2011-11-25 18:23:15)

        Review request for wave.

        Summary

        -------

        This patch solves the problem in my case.

        I'm running ubuntu x64, and experienced the same problem.

        What I did is simply change the parameter type passed to the thenReturn() method:

        * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest

        * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest

        This addresses bug WAVE-298.

        https://issues.apache.org/jira/browse/WAVE-298

        Diffs

        -----

        /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126

        /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126

        Diff: https://reviews.apache.org/r/2932/diff

        Testing

        -------

        ant test runs with no errors on ubuntu x64 10.04

        Thanks,

        Antonio

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-26 10:12:55, Yuri Zelikov wrote: > Thanks for contributing to the Apache Wave project. Besides minor comments this patch LGTM. > I will address the comments by myself and commit if it's OK with you. Antonio Bello wrote: Yeah sure - thanks for "fixing" my code. I think I still have to read some rules and conventions about how to write code and how to submit it. Also, I plan to give my contribution to this project on a regular basis, watching and trying to solve issues at beginning, but I'd like to get more involved in development at a later stage, when I'll have a better understanding of the architecture. Antonio Yuri Zelikov wrote: This is great, thanks! Antonio Bello wrote: My pleasure I'm a bit confused about what repository to use... svn, git@apache, git@github? I wouldn't want I work on the wrong one Yuri Zelikov wrote: For getting the latest code you can use either the SVN repository or the Git mirror SVN: https://svn.apache.org/repos/asf/incubator/wave/trunk/ Git mirror: git://git.apache.org/wave.git If you feel ready to submit a patch - then just use this Review Board for this. Yuri Zelikov wrote: Can you please close this review request? Ditto. Please close this review request? Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/#review3517 ----------------------------------------------------------- On 2011-11-25 18:23:15, Antonio Bello wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2932/ ----------------------------------------------------------- (Updated 2011-11-25 18:23:15) Review request for wave. Summary ------- This patch solves the problem in my case. I'm running ubuntu x64, and experienced the same problem. What I did is simply change the parameter type passed to the thenReturn() method: * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest * replace ImmutableMap.of() with new Hashtable<String, String[]>() in DataApiServletTest This addresses bug WAVE-298 . https://issues.apache.org/jira/browse/WAVE-298 Diffs ----- /test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java 1206126 /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java 1206126 Diff: https://reviews.apache.org/r/2932/diff Testing ------- ant test runs with no errors on ubuntu x64 10.04 Thanks, Antonio
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        41d 12h 45m 1 Yuri Zelikov 10/Dec/11 00:29

          People

          • Assignee:
            Yuri Zelikov
            Reporter:
            Thomas Leonard
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development