[WAVE-291] Disabled submenu in toolbar incorrectly opens when clicked

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Web Client
• Assignee: Unassigned
• Reporter: Thomas Broyer
• Created: 01/Sep/11 12:35
• Updated: 02/Sep/11 14:06

Description

When adding a submenu in a toolbar, clicking on the corresponding button always opens the menu, whether the SubmenuToolbarView is in State.DISABLED or not.
This is because a submenu is made of a ToolbarToggleButton and a SubmenuToolbarWidget (which itself is an AbstractToolbarButton) both controlling the same ToolbarButtonUi.
Calling setState(State.DISABLED) on the SubmenuToolbarWidget (returned as a SubmenuToolbarView by the addSubmenu method) calls setState(State.DISABLED) on the ToolbarButtonUi so the button appears disabled; but the ToolbarToggleButton isn't updated, so it's internal check for !isDisabled() in its onClick method fails and it always toggles the button.