[WAGON-582] HttpMethodConfiguration#copy() performs a shallow copy only

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.4
• Fix Version/s: 3.4.0
• Component/s: wagon-http
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 09/Mar/20 21:45
• Updated: 09/Mar/20 22:05
• Resolved: 09/Mar/20 22:05

Description

The copy() method does the following: copy.setHeaders( getHeaders() ); same for parameters. It passes the reference of the Properties object w/o creating a new instance and copying the content. All subsequent instances share those and may modify those.

To make things worse HttpConfiguration.DEFAULT_PUT is passed for PUT. If a previous configuration modified http.protocol.expect-continue to false this singleton is modified too.