[WAGON-557] Integer overflow prevents optimal buffer size selection for large artifacts

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.2
• Fix Version/s: 3.3.3
• Component/s: wagon-provider-api
• Assignee: Michael Osipov
• Reporter: Olaf Otto
• Created: 09/May/19 14:15
• Updated: 16/Jun/19 08:51
• Resolved: 10/May/19 20:34

Description

The change introduced for WAGON-537 was slightly modified from the original PR (see https://github.com/apache/maven-wagon/pull/51/commits/e4d34eb86906317536f2adfde4f70f3f45cb34c4) and introduced a wrap around in getBufferCapacityForTransfer:

final int numberOfBufferSegments = (int)
            numberOfBytes / ( BUFFER_SEGMENT_SIZE * MINIMUM_AMOUNT_OF_TRANSFER_CHUNKS );

Here, the integer cast is applied prior to the division, resulting in negative numbers for  artifact sizes > 2 GB. This means the buffer capacity falls back to the default buffer size (4k) for such artifacts. While the overall performance is still better than prior to WAGON-537, this significantly reduces potential transfer speed for such large artifacts.

Issue Links

• links to: GitHub Pull Request #54