[WAGON-258] SSH / SCP -o options should be quoted

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.0-beta-5
• Component/s: wagon-ssh-external
• Environment: Maven 2.1.0 and Java 1.5.0_15
• Assignee: Unassigned
• Reporter: Timothy Riley
• Created: 14/Apr/09 23:41
• Updated: 25/Nov/14 14:49
• Resolved: 25/Nov/14 14:49

Description

I'm currently using Reflection Secure IT, which requires all SSH / SCP -o options
be placed in quotations unfortunately I cannot deviate from this technology.
The problem is that ScpExternalWagon.java places the BatchMode option as an
argument without quotes resulting in a failing SSH command.

Line 251 of ScpExternalWagon.java
cl.createArgument().setValue( "BatchMode yes" );

Results in...
ssh -o BatchMode yes [REST OF COMMAND]

What I need is...
ssh -o "BatchMode yes" [REST OF COMMAND]

Issue Links

• is related to: MNG-4133 ssh-external wagon can not be overridden on its own
• is related to: WAGON-312 Cannot download folders with spaces via SCP