Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: XEP0060 PubSub
    • Labels:
      None

      Description

      Instead of instantiating the model whilst creating the handlers, use storage providers like the other handlers do.

      1. VYSPER-64.1.patch
        22 kB
        Michael Jakl

        Activity

        Hide
        Michael Jakl added a comment -

        Fixed in rev788961 (forgot to include a reference to this JIRA).

        Instead of a NullObject[1], I'm using the in-memory storage provider as default when no other storage provider is configured.

        • Reworked the NullPersistenceManager into two separate StorageProviders (one for collection nodes, one for leaf nodes).
        • The new storage providers are default (configured at object creation) and keep all objects in memory (fallback if no other storage provider is configured).
        • Moved all storage related classes into their own package (storageprovider).
        • Applied uniform naming (storage provider instead of persistence manager).

        1: http://en.wikipedia.org/wiki/Null_object

        Show
        Michael Jakl added a comment - Fixed in rev788961 (forgot to include a reference to this JIRA). Instead of a NullObject [1] , I'm using the in-memory storage provider as default when no other storage provider is configured. Reworked the NullPersistenceManager into two separate StorageProviders (one for collection nodes, one for leaf nodes). The new storage providers are default (configured at object creation) and keep all objects in memory (fallback if no other storage provider is configured). Moved all storage related classes into their own package (storageprovider). Applied uniform naming (storage provider instead of persistence manager). 1: http://en.wikipedia.org/wiki/Null_object
        Hide
        Michael Jakl added a comment - - edited

        This patch is the first step (refactoring) towards persistence managers. It separates data storage and model logic.

        It's not complete (yet working), but coherent enought to form a patch.

        (Note: I prepared this patch using git, so if there are any problems, please let me know!)

        Show
        Michael Jakl added a comment - - edited This patch is the first step (refactoring) towards persistence managers. It separates data storage and model logic. It's not complete (yet working), but coherent enought to form a patch. (Note: I prepared this patch using git, so if there are any problems, please let me know!)

          People

          • Assignee:
            Michael Jakl
            Reporter:
            Michael Jakl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development