VYSPER
  1. VYSPER
  2. VYSPER-306

Websocket plugin too tightly bound to Jetty

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: None
    • Component/s: extension

      Description

      I tried to integrate the websocket plugin into our system. Instead of setting up a jetty endpoint I wanted to use an existing server. This works fine if the server you want to integrate against is a Jetty server. In my case, the server is a Tomcat server. This resulted in Jetty-based errors when accessing the target address. The implementation should be server-independent, so that it could be used in more contexts.

        Activity

        Hide
        Niklas Gustavsson added a comment -

        Agreed. When I wrote the existing code, Jetty was the only Java app server that implemented web sockets. Now that Tomcat does as well, we should look at redesigning our code to work in a more generic manner. There's also JSR 356 which might make this moot in the future but let's worry about that when it gets done.

        If you got a patch for making Vysper work with Tomcat, I'll be happy to review it. Otherwise, I'll have a look at it sometimes in the near future.

        Show
        Niklas Gustavsson added a comment - Agreed. When I wrote the existing code, Jetty was the only Java app server that implemented web sockets. Now that Tomcat does as well, we should look at redesigning our code to work in a more generic manner. There's also JSR 356 which might make this moot in the future but let's worry about that when it gets done. If you got a patch for making Vysper work with Tomcat, I'll be happy to review it. Otherwise, I'll have a look at it sometimes in the near future.
        Hide
        Stig Runar Vangen added a comment -

        https://issues.apache.org/bugzilla/show_bug.cgi?id=51181
        WebSocket support has been added to Tomcat 7.0.27. Lastest version for download is 7.0.26.

        http://java.dzone.com/articles/tomcat-websockets-html5
        This guy made an implementation for Tomvat 7.0.14. Provided here as a Tomcat patch.

        Based on this, I think it is best to wait until the next Tomcat version is officially released before starting work on a Tomcat implementation. I initially thought of making a wrapper myself on top of the current Servlet API, but this might not be possible.

        Show
        Stig Runar Vangen added a comment - https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 WebSocket support has been added to Tomcat 7.0.27. Lastest version for download is 7.0.26. http://java.dzone.com/articles/tomcat-websockets-html5 This guy made an implementation for Tomvat 7.0.14. Provided here as a Tomcat patch. Based on this, I think it is best to wait until the next Tomcat version is officially released before starting work on a Tomcat implementation. I initially thought of making a wrapper myself on top of the current Servlet API, but this might not be possible.
        Hide
        Fabio Mancinelli added a comment -

        I've created a similar issue for the BOSH plugin, because I think that we have the same problem there (VYSPER-307)

        Show
        Fabio Mancinelli added a comment - I've created a similar issue for the BOSH plugin, because I think that we have the same problem there ( VYSPER-307 )
        Hide
        Niklas Gustavsson added a comment -

        Implemented support for Tomcat (and generalized the code in general) in r1328861.

        Show
        Niklas Gustavsson added a comment - Implemented support for Tomcat (and generalized the code in general) in r1328861.

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Stig Runar Vangen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development