[VFS-758] Webdav4s provider does not make https requests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Assignee: Gary D. Gregory
• Reporter: Woonsan Ko
• Created: 14/Feb/20 16:14
• Updated: 31/Oct/20 23:53
• Resolved: 31/Oct/20 23:53

Description

Reported by https://github.com/ddg-igh:

• https://github.com/apache/commons-vfs/pull/81

When using webdav4s the requests will be send as "http" and not "https".
So this will always fail when the webdav server does not allow "http" requests."

I was also able to reproduce through shell:

$ cd commons-vfs2-examples
$ mvn -Pshell -Dwebdav4
VFS Shell null
cd webdav4s://localhost
Command failed:
...
Caused by: org.apache.http.conn.HttpHostConnectException: Connect to localhost:80 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused (Connection refused)
...

• which shows that it makes an http (port 80), not https (port 443).
• it should have made https requests for 'webdav4s'.

Issue Links

• is duplicated by: VFS-783 WEBDAV4 GenericURLFileName hardcoded scheme("http") won't work for https connection
• links to: GitHub Pull Request #83