Uploaded image for project: 'Commons VFS'
  1. Commons VFS
  2. VFS-678

LGTM (automatic code review) issues

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 1.0
    • Labels:
      None

      Description

      The LGTM.com code review system has some issues with VFS2 code:

      https://lgtm.com/projects/g/apache/commons-vfs/alerts/?mode=list

      Namely:

      DefaultCryptor.java: 111,114 - index might be equal to array length
      MonitorInputStream.java: 60, 86 - method overwrites a synchronized method
      UserAuthenticationData.java: 132 - test always false
      Shell.java: 157 - array to string
      DefaultFileMonitor.java: 493: - may be null
      ShowFileTask.java: 126 - resource leak
      FileName.java: 144 - javadoc
      CompressedFileFileProvider.java: 42 - javadoc

        Attachments

          Activity

            People

            • Assignee:
              b.eckenfels Bernd Eckenfels
              Reporter:
              b.eckenfels Bernd Eckenfels
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: