[VFS-524] A URI with an IPv6 address can't be parsed correctly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.10.0
• Assignee: Unassigned
• Reporter: Alex
• Created: 07/May/14 02:04
• Updated: 25/Oct/23 11:03
• Resolved: 25/Oct/23 11:03

Description

I am using apache commons vfs2 to read and download file in ipv6 enviroment, but it seems can't parse out ipv6 address correctly
The URI is just like:
ftp://[2002:9ba:b4e:6:a052:5792:c0c9:2330]/test

The error message:
Invalid absolute URI "ftp://[2002:9ba:b4e:6:a052:5792:c0c9:2330]/test".

Caused by : Expecting / to follow the hostname in URI "ftp://[2002:9ba:b4e:6:a052:5792:c0c9:2330]/test".

Deep into the code, I found the root cause is that HostFileNameParser's extractHostName can't parse out the host name correctly

/**
     * Extracts the hostname from a URI.  The scheme://userinfo@ part has
     * been removed.
     */
    protected String extractHostName(final StringBuilder name)
    {
        final int maxlen = name.length();
        int pos = 0;
        for (; pos < maxlen; pos++)
        {
            final char ch = name.charAt(pos);
            if (ch == '/' || ch == ';' || ch == '?' || ch == ':'
                || ch == '@' || ch == '&' || ch == '=' || ch == '+'
                || ch == '$' || ch == ',')
            {
                break;
            }
        }
        if (pos == 0)
        {
            return null;
        }

        final String hostname = name.substring(0, pos);
        name.delete(0, pos);
        return hostname;
    }

From the code, we are able to know it will parse out the host name by colon, but for ipv6, it will get a wrong host name

There is the same problem with the other protocol like sftp and cifs

Issue Links

• links to: GitHub Pull Request #438