Uploaded image for project: 'Commons VFS'
  1. Commons VFS
  2. VFS-352

ZipFileSystem makes improper assumptions about FileCache

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 2.1
    • Labels:
    • Environment:

      Java 1.6

      Description

      Upon init(), ZipFileSystem enumerates all the zip file entries and stores them in the global FilesCache as well as a "strongRef" array.

      The ZipFileSystem implementation assumes that this will be sufficient to keep all entries in the cache, and so if the cache misses in AbstractFileSystem, ZipFileSystem assumes that the file does not exist and returns an imaginary file.

      This implementation assumes that the WeakRefFilesCache is being used. If NullFilesCache or LRUFilesCaches is used, these assumptions will fail and ZipFileSystem will fail to resolve valid existing files within the system.

      ZipFileSystem should maintain its own internal cache instead.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              alexbedatadriven Alex Bertram
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified