[VFS-327] UriParser.canonicalizePath possible NPE for filenameParser

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1
• Assignee: Unassigned
• Reporter: Sebb
• Created: 02/Nov/10 19:10
• Updated: 19/May/16 18:25
• Resolved: 16/May/12 17:33

Description

The UriParser.canonicalizePath method has a possible NPE for filenameParser:

[495]   boolean match = value == '%'
[496]          || (fileNameParser != null && fileNameParser.encodeCharacter(value));
...
[511]    else if (fileNameParser.encodeCharacter(ch))

Line 496 allows for fileNameParser being null, but line 511 does not.

As far as I can tell, the method is never called with a null parser, so it should be safe to omit the null check in line 496.
If the code can ever be called with a null parser, then the code at line 511 needs to be fixed.