[VELTOOLS-57] ServletToolboxManager fails for .war files

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3
• Component/s: VelocityView
• Environment: irrelevant
• Assignee: Nathan Bubna
• Reporter: Justin Patterson
• Created: 04/Mar/06 00:54
• Updated: 05/Mar/06 04:28
• Resolved: 05/Mar/06 04:28

Description

When webapps are deployed as .war files and the ServletToolboxManager is loaded from a shared location (mine is in shared/lib on Tomcat), the getInstance(ServletContext,String) method always returns the same manager. This is because the call to ServletContext.getRealPath(String) method, whose return value is used as the key into the managersMap, returns null when the webapp is deployed as a jar, per the servlet API. So, all ServletContext's end up getting/putting their managers using the null key into the managersMap .

This is easy to fix. You just need another way to scope the toolbox filename based on the input ServletContext that's guaranteed to return something unique.