Velocity Tools
  1. Velocity Tools
  2. VELTOOLS-57

ServletToolboxManager fails for .war files

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: VelocityView
    • Labels:
      None
    • Environment:
      irrelevant

      Description

      When webapps are deployed as .war files and the ServletToolboxManager is loaded from a shared location (mine is in shared/lib on Tomcat), the getInstance(ServletContext,String) method always returns the same manager. This is because the call to ServletContext.getRealPath(String) method, whose return value is used as the key into the managersMap, returns null when the webapp is deployed as a jar, per the servlet API. So, all ServletContext's end up getting/putting their managers using the null key into the managersMap .

      This is easy to fix. You just need another way to scope the toolbox filename based on the input ServletContext that's guaranteed to return something unique.

      1. patch
        0.8 kB
        Justin Patterson

        Activity

        Justin Patterson created issue -
        Nathan Bubna made changes -
        Field Original Value New Value
        Fix Version/s 2.0 [ 12310350 ]
        Fix Version/s 1.3 [ 12310349 ]
        Justin Patterson made changes -
        Affects Version/s 1.1 [ 12310347 ]
        Affects Version/s 1.2 [ 12310348 ]
        Justin Patterson made changes -
        Attachment patch [ 12323718 ]
        Nathan Bubna made changes -
        Fix Version/s 2.0 [ 12310350 ]
        Assignee Nathan Bubna [ nbubna ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]

          People

          • Assignee:
            Nathan Bubna
            Reporter:
            Justin Patterson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development