Velocity Tools
  1. Velocity Tools
  2. VELTOOLS-55

Add URLResourceLoader to VelocityTools 1.3

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: None
    • Component/s: VelocityView
    • Labels:
      None

      Description

      Geir created a new resource loader that can load velocity files (.vm) from any URL, not just from the filesystem or from the webapp.
      This is very useful for me since sometimes I have to have apps read .vm files from different sources (a CDN server). This file is
      already in the main Velocity branch under /whiteboard/geir/ and basially just has to be copied over into VelocityTools.

        Activity

        Hide
        Nathan Bubna added a comment -

        docs updated in revisions 475595 and 475596

        Show
        Nathan Bubna added a comment - docs updated in revisions 475595 and 475596
        Hide
        Nathan Bubna added a comment -

        Committed in Velocity revision 385614
        http://svn.apache.org/viewcvs?rev=385614&view=rev

        leaving the issue open as a reminder to update docs...

        Show
        Nathan Bubna added a comment - Committed in Velocity revision 385614 http://svn.apache.org/viewcvs?rev=385614&view=rev leaving the issue open as a reminder to update docs...
        Hide
        Nathan Bubna added a comment -

        Well, it's always good if docs are updated for new stuff. I'm not sure though which will need/want attention due to adding this resource loader (except, of course, the changelog). If i get a chance to look into it, i will. though i have a very busy week ahead.

        Show
        Nathan Bubna added a comment - Well, it's always good if docs are updated for new stuff. I'm not sure though which will need/want attention due to adding this resource loader (except, of course, the changelog). If i get a chance to look into it, i will. though i have a very busy week ahead.
        Hide
        Will Glass-Husain added a comment -

        Yes, let's do that. Do the docs need to be updated?

        Show
        Will Glass-Husain added a comment - Yes, let's do that. Do the docs need to be updated?
        Hide
        Nathan Bubna added a comment -

        Ok, i took some time to test out my changes, and the URLResourceLoader seems to be working great. upon further thought, however, i really don't think it belongs in VelocityTools. it doesn't use any veltools classes, isn't a tool (in the veltools sense), and doesn't use j2ee classes.

        so, barring any objections, i'm going to put it into the core for 1.5.

        Charles, it'd be great to have you (who will use it) test it out before we push a 1.5 release out.

        Show
        Nathan Bubna added a comment - Ok, i took some time to test out my changes, and the URLResourceLoader seems to be working great. upon further thought, however, i really don't think it belongs in VelocityTools. it doesn't use any veltools classes, isn't a tool (in the veltools sense), and doesn't use j2ee classes. so, barring any objections, i'm going to put it into the core for 1.5. Charles, it'd be great to have you (who will use it) test it out before we push a 1.5 release out.
        Hide
        Nathan Bubna added a comment -

        Charles (and others),

        i felt rather in need of a break from paid work headaches and busyness for a few minutes tonight, so i hacked on this for a little while...

        what's attached is an updated, improved, and largely untested URLResourceLoader. it's Velocity 1.5-dev dependent (largely due to logging), but doesn't need to remain so. i currently have it as being in the Generic Tools package, but if someone were willing to test it and/or write some JUnit tests for it, i think it may be core worthy. it doesn't really fit all that great with the rest of the tools, and i'm still impressed by your "been using it successfully for three years" endorsement.

        so in particular, i'd like to know if the improvements work for you, but if you or someone else had time to provide some tests that would also help move things along.

        Show
        Nathan Bubna added a comment - Charles (and others), i felt rather in need of a break from paid work headaches and busyness for a few minutes tonight, so i hacked on this for a little while... what's attached is an updated, improved, and largely untested URLResourceLoader. it's Velocity 1.5-dev dependent (largely due to logging), but doesn't need to remain so. i currently have it as being in the Generic Tools package, but if someone were willing to test it and/or write some JUnit tests for it, i think it may be core worthy. it doesn't really fit all that great with the rest of the tools, and i'm still impressed by your "been using it successfully for three years" endorsement. so in particular, i'd like to know if the improvements work for you, but if you or someone else had time to provide some tests that would also help move things along.
        Hide
        Nathan Bubna added a comment -

        Let's not get in the habit of always automatically assigning all issues for Tools to me. I'll assign them to myself if/when i'm sure i'm going to deal with them. Otherwise, I'd like others to feel free to work on them too.

        Show
        Nathan Bubna added a comment - Let's not get in the habit of always automatically assigning all issues for Tools to me. I'll assign them to myself if/when i'm sure i'm going to deal with them. Otherwise, I'd like others to feel free to work on them too.

          People

          • Assignee:
            Nathan Bubna
            Reporter:
            Charles N. Harvey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development