Velocity Tools
  1. Velocity Tools
  2. VELTOOLS-52

ValidatorTool javascript generator can generate invalid Javascript

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2
    • Component/s: VelocityStruts
    • Labels:
      None
    • Environment:
      Using JDK1.4.2 / Linux 2.4 kernel / Tomcat 4.1

      Description

      ValidatorTool can create invalid javascript in a few situations.

      Here is an example of such a situation and also an example of the invalid javascript it generates.

      Suppose you have the following dynamic action form validation rules defined (this is actually text field which is intended to be used as an "other" input when a drop-down has the value of "Other").

      <pre>
      <field property="selectOther"
      depends="validwhen,maxlength"
      page="1">
      <arg0 key="prompt.selectOther"/>
      <arg1 name="maxlength" key="$

      {var:maxlength}

      " resource="false" />
      <var><var-name>maxlength</var-name><var-value>255</var-value></var>
      <var>
      <var-name>test</var-name>
      <var-value>
      (((select == "Other") and (this != null)) or
      (select != "Other"))
      </var-value>
      </var>
      </field>
      </pre>

      When ValidatorTool generates Javascript for this, you get the following:

      <pre>
      .
      .
      .
      this.a3 = new Array("orgTypeOther", "The field Organization Type cannot be greater than 255 characters.", new Function ("varName", "this.maxlength='255'; this.test='(((orgType == "Other") and (this != null)) or
      (orgType != "Other"))'; return this[varName];"));
      .
      .
      .
      </pre>

      Note that there is a newline in the string literal (invalid) and that the double-quotes used in my "validwhen" rule have not been escaped, which prematurely ends the double-quoted string starting with <code>"this.maxlength</code>, which really confuses the Javascript interpreter.

      It turns out that switching from double-quotes to single-quotes doesn't help, since there are also single-quoted strings within that double-quoted string, so basically it won't work no matter what you do (since backslash-escaping the quotes will cause the validwhen test itself to become invalid.

      I see two solutions: properly escape the variable values being dumped into Javascript, or avoid adding the "test" variable to the Javascript, since it will be ignored, anyway.

      I propose fixing the escaping, since there may be other validator "var" values with this same problem.

      1. ValidatorTool.diff
        4 kB
        Christopher Schultz

        Activity

        Christopher Schultz created issue -
        Christopher Schultz made changes -
        Field Original Value New Value
        Attachment ValidatorTool.diff [ 12314909 ]
        Nathan Bubna made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Christopher Schultz made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Nathan Bubna
            Reporter:
            Christopher Schultz
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development