Velocity Tools
  1. Velocity Tools
  2. VELTOOLS-117

standard tools keys not overwrittable when running in deprecationSupportMode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Invalid
    • Affects Version/s: 2.x
    • Fix Version/s: 2.x
    • Component/s: VelocityView
    • Labels:
      None

      Description

      Is it intended that standard tools keys not overwrittable when running in deprecationSupportMode?

      Contrary to the new view.ViewtoolContext, The view.context.ChainedContext does not allow standard tools keys to be overwritten.

      If I remember correctly, tools keys were not overwrittable in 1.x. So it may be regarded as a normal behaviour not to allow this in deprecationSupportMode, but it is not, since tools keys have changed! Better allow tools keys to be overwrittable, since this hardly breaks compatibility (maybe for broken templates).

        Activity

        Claude Brisson created issue -
        Hide
        Nathan Bubna added a comment -

        You're right. We should allow tool keys to be overwritten by default regardless of deprecationSupportMode.

        Any chance you want to fix this? I don't want to keep doing everything if it is encouraging the rest of you to tune out and miss votes and such.

        Show
        Nathan Bubna added a comment - You're right. We should allow tool keys to be overwritten by default regardless of deprecationSupportMode. Any chance you want to fix this? I don't want to keep doing everything if it is encouraging the rest of you to tune out and miss votes and such.
        Hide
        Claude Brisson added a comment -

        My mistake. I had an old snapshot jar in the classpath. The behaviour is correct since the last ToolsViewContext rewrite.

        Show
        Claude Brisson added a comment - My mistake. I had an old snapshot jar in the classpath. The behaviour is correct since the last ToolsViewContext rewrite.
        Claude Brisson made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.x [ 12310350 ]
        Resolution Invalid [ 6 ]
        Claude Brisson made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Claude Brisson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development