Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-815

MapGetExecutor is very slow [PATCH]

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.7.x, 2.0
    • 2.0
    • Engine

    Description

      When MapGetExecutor is instantiated by the UberspectImpl it iterates through all the interfaces implemented by the object's Class to figure out whether it's a java.util.Map

      This could be replaced by an instance of test on the object received by the Uberspect which would be much faster. We noticed this as a hotspot after upgrading to 1.6 through our Performance Tests JProfiler output.

      I am happy to provide a patch for this, it would be nice to get this on the maintenance branch as well if possible, so that we don't have to maintain a fork until we upgrade.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cbrisson Claude Brisson
            ohernandez Oswaldo Hernandez
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment