[VELOCITY-804] RuntimeInstance throws exception on init() but stay with "initializing" state

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7
• Fix Version/s: 2.0
• Component/s: Engine
• Environment: Linux
• Assignee: Unassigned
• Reporter: Felipe Maschio
• Created: 27/May/11 22:02
• Updated: 07/Jan/18 15:46
• Resolved: 17/Jul/16 11:15

Description

init() throws an exception and below is the cause:

Caused by: java.io.FileNotFoundException: velocity.log (Permission denied)

That's ok, I just need to change the permissions on webapps directory from my tomcat. But I needed to restart the server because the "initializing" param is true yet.
This is my sugestion to fix that (just a try{}funally{}):

public synchronized void init()
throws Exception
{

if (!initialized && !initializing)
{
try

{ initializing = true; log.trace("*******************************************************************"); log.debug("Starting Apache Velocity [e-mail]@ (compiled: @build.time@)"); log.trace("RuntimeInstance initializing."); initializeProperties(); initializeLog(); initializeResourceManager(); initializeDirectives(); initializeEventHandlers(); initializeParserPool(); initializeIntrospection(); /* * initialize the VM Factory. It will use the properties * accessable from Runtime, so keep this here at the end. */ vmFactory.initVelocimacro(); log.trace("RuntimeInstance successfully initialized."); }

finally

{ initializing = false; }

initialized = true;
}