[VELOCITY-776] "velocimacro.permissions.allow.inline.local.scope" makes VelocityEngine not threadsafe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.4
• Fix Version/s: 2.0
• Component/s: Engine
• Environment: Sun java jdk1.6.0_21, Ubuntu 10.04
• Assignee: Claude Brisson
• Reporter: Simon Kitching
• Created: 01/Sep/10 21:42
• Updated: 07/Jan/18 15:46
• Resolved: 17/Jul/16 23:34

Description

The attached unit test shows that when "velocimacro.permissions.allow.inline.local.scope" is set to true, and multiple threads use the same VelocityEngine instance then macros sometimes don't get expanded and the #macroname call remains in the output text.

Notes:

• running test method "testMultipleEvals" (single threaded case) always succeeds
• running test method "testMultiThreadMultipleEvals" always fails
• commenting out the allow.inline.local.scope line makes the multithread test pass (but of course has other side-effects)

Interestingly, for the multithread case it seems that 1 thread always succeeds and N-1 threads fail.

Issue Links

• is duplicated by: VELOCITY-796 Velocity #parse not parsing content.
• is duplicated by: VELOCITY-811 Concurrency problems with rendering macros
• is superceded by: VELOCITY-797 Inline macros need to be kept with their Template, not centrally managed