Velocity
  1. Velocity
  2. VELOCITY-731

Velocity 1.6 performance is degraded by introduced toString() calls

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6, 1.6.1, 1.6.2
    • Fix Version/s: 1.6.x, 1.7
    • Component/s: Engine
    • Labels:
      None
    • Environment:
      Apache Velocity 1.6.2

      Description

      As part of VELOCITY-531, r686428 introduced frequent calls to toString() just to check if toString() != null. If toString() implementations are slightly complex, and very frequently executed, these calls will degrade the site performance. Are they at all necessary? What kind of object would use null as a return value for toString()? Is it possible to remove these toString() calls from the velocity code again?

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12551572 ] jira [ 12552457 ]
        Mark Thomas made changes -
        Workflow jira [ 12473621 ] Default workflow, editable Closed status [ 12551572 ]
        Nathan Bubna made changes -
        Fix Version/s 1.6.2 [ 12313574 ]
        Affects Version/s 1.6.2 [ 12313574 ]
        Affects Version/s 1.6.1 [ 12313544 ]
        Nathan Bubna made changes -
        Fix Version/s 1.6.x [ 12314172 ]
        Nathan Bubna made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.6.2 [ 12313574 ]
        Fix Version/s 1.7 [ 12313453 ]
        Resolution Fixed [ 1 ]
        Jörgen Rydenius made changes -
        Field Original Value New Value
        Attachment configurable_tostring_nullcheck_patch.txt [ 12417264 ]
        Jörgen Rydenius created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Jörgen Rydenius
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development