Velocity
  1. Velocity
  2. VELOCITY-668

Minor performance tweaks based on Findbugs findings

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Mainly change two inner classes to static inner classes and a few other slight modifications. See the patch.

        Activity

        Hide
        Byron Foster added a comment -

        Thanks Jarkko, Nathan, I didn't add anything to the change log given the nature of the changes, let me know if this appropriate.

        Show
        Byron Foster added a comment - Thanks Jarkko, Nathan, I didn't add anything to the change log given the nature of the changes, let me know if this appropriate.
        Hide
        Jarkko Viinamäki added a comment -

        Thanks. Note that you need to run "ant parser" and commit generated files (Parser.java etc) because otherwise changes made to Parser.jjt won't be included in the build.

        Show
        Jarkko Viinamäki added a comment - Thanks. Note that you need to run "ant parser" and commit generated files (Parser.java etc) because otherwise changes made to Parser.jjt won't be included in the build.
        Hide
        Byron Foster added a comment -

        Ok, thanks, done

        Show
        Byron Foster added a comment - Ok, thanks, done
        Hide
        Nathan Bubna added a comment -

        My "rule of thumb" for the change log is to note it if one of the following are true:

        a) it has an issue associated with it (like this one), especially when committing someone else's patch.
        b) when it's a new feature
        c) it fixes a user-reported problem
        d) it introduces a backward compatibility issue

        so, yeah, please put this in the change log.

        Show
        Nathan Bubna added a comment - My "rule of thumb" for the change log is to note it if one of the following are true: a) it has an issue associated with it (like this one), especially when committing someone else's patch. b) when it's a new feature c) it fixes a user-reported problem d) it introduces a backward compatibility issue so, yeah, please put this in the change log.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jarkko Viinamäki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development