Velocity
  1. Velocity
  2. VELOCITY-593

Remove class map from FieldMethodizer

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.6
    • Component/s: Engine
    • Labels:
      None

      Description

      According to the API docs of Field.get():

      If the underlying field is a static field, the obj argument is ignored; it may be null.

      So there is no need to waste memory on keeping a class map (besides, if one needs to know the class defining a field, there is Field.getDeclaringClass()).

      1. VELOCITY-593.patch
        1 kB
        Benjamin Bentmann

        Activity

        Hide
        Nathan Bubna added a comment -

        You're quite right. Thanks! Fixed in revision 652755

        Show
        Nathan Bubna added a comment - You're quite right. Thanks! Fixed in revision 652755

          People

          • Assignee:
            Unassigned
            Reporter:
            Benjamin Bentmann
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development