Velocity
  1. Velocity
  2. VELOCITY-584

Change the #include directive ignore the SSI version of include

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.5
    • Fix Version/s: 2.x
    • Component/s: Engine
    • Labels:
      None

      Description

      When processing a file that happens to have the SSI version of 'include' in it, the velocity engine breaks.

      There are many cases where we end up with files that contain both, before they are cleaned up.

      <!-#include file="wisdom.inc"->

      Essentially, if it sees that syntax, it needs to ignore the include. A suggestion would be to check for any amount of whitespace after the #include, and then "file=". I don't think that will step on proper Velocity include syntax.

        Issue Links

          Activity

          Tim White created issue -
          Tim White made changes -
          Field Original Value New Value
          Description When processing a file that happens to have the SSI version of 'include' in it, the velocity engine breaks.

          There are many cases where we end up with files that contain both, before they are cleaned up.

          <!--#include file="wisdom.inc"-->

          Essentially, if it sees that syntax, it needs to ignore the include. A suggestion would be to check for any amount of whitespace, and then "file".
          When processing a file that happens to have the SSI version of 'include' in it, the velocity engine breaks.

          There are many cases where we end up with files that contain both, before they are cleaned up.

          <!--#include file="wisdom.inc"-->

          Essentially, if it sees that syntax, it needs to ignore the include. A suggestion would be to check for any amount of whitespace after the #include, and then "file=". I don't think that will step on proper Velocity include syntax.
          Nathan Bubna made changes -
          Fix Version/s 2.0 [ 12310291 ]
          Resolution Won't Fix [ 2 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Jarkko Viinamäki made changes -
          Link This issue relates to VELOCITY-661 [ VELOCITY-661 ]
          Mark Thomas made changes -
          Workflow jira [ 12422387 ] Default workflow, editable Closed status [ 12551563 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12551563 ] jira [ 12552448 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Tim White
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development