[VELOCITY-565] EvaluateContext does not take account of inner.localContext

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6
• Assignee: William Glass-Husain
• Reporter: William Glass-Husain
• Created: 17/Sep/07 07:06
• Updated: 06/Oct/07 23:44
• Resolved: 06/Oct/07 23:44

Description

the following vtl does not render what is, IMHO, expected :

#macro(testEval $expr)

#foreach($value in ["val1", "val2"])
value is : #evaluate( $expr )
#end
#end

#testEval( "${value}" )

renders :

value is : ${value}
value is : ${value}

The reason is that EvaluateContext ctor assigns 'inner.getBaseContext()'
to instance variable 'innerContext', and getBaseContext() does not
return VMContext localContext refs (of the #foreach directive).

Changing the EvaluateContext ctor so that 'innerContext' is set to
'inner' allow velocity to render the right result :

value is : val1
value is : val2

But I'm not sure this would be a correct fix, should the VMContext
return all current refs ? Could you tell me what the normal behavior is
and what is the way all that stuff sould work ?

Etienne Massip