Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5 beta2
    • Fix Version/s: 1.6
    • Component/s: Engine
    • Labels:
      None

      Description

      The test:

      ===
      public void testU() throws Exception

      { VelocityEngine ve = new VelocityEngine(); ve.init(); Context context = new VelocityContext(); StringWriter writer; writer = new StringWriter(); ve.evaluate(context, writer, "test","#set($v = \"\\u0061\")$v"); //assertEquals("a", writer.toString()); }

      ===

      I think "\u0061" shoud produce "a", see VELOCITY-519. But if not, this should produce string "\u0061", literally, but not exception, as now.

        Issue Links

          Activity

          Hide
          Nathan Bubna added a comment -

          Ok, the fix and an improved/combined version of your test case are committed. All tests pass.

          Show
          Nathan Bubna added a comment - Ok, the fix and an improved/combined version of your test case are committed. All tests pass.
          Hide
          Nathan Bubna added a comment -

          Argh, that's not right. And since this apparently hasn't been working, it looks like adding unicode is at least backwards compatible. In that case, i guess i'm fine with this going either way. Either literally producing "\u0061" or producing "a". If people want unicode in VTL string definitions, i won't protest.

          I'm still opposed to having \n \r \" or other such escaping. Especially since we can now put line breaks directly in the strings:

          #set( $foo = " this has a line
          break in it" )

          And we should hopefully soon be able to do "" or '' escaping for quotes (assuming Geir finds the changes he once made to enable that or else one of us duplicates the effort).

          Show
          Nathan Bubna added a comment - Argh, that's not right. And since this apparently hasn't been working, it looks like adding unicode is at least backwards compatible. In that case, i guess i'm fine with this going either way. Either literally producing "\u0061" or producing "a". If people want unicode in VTL string definitions, i won't protest. I'm still opposed to having \n \r \" or other such escaping. Especially since we can now put line breaks directly in the strings: #set( $foo = " this has a line break in it" ) And we should hopefully soon be able to do "" or '' escaping for quotes (assuming Geir finds the changes he once made to enable that or else one of us duplicates the effort).

            People

            • Assignee:
              Unassigned
              Reporter:
              Stepan Koltsov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development