[VELOCITY-449] Velocity Uberspector behaves differently for get(String) and put(String, Object) methods

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 1.5
• Assignee: Unassigned
• Reporter: Henning Schmiedehausen
• Created: 08/Jul/06 22:29
• Updated: 08/Mar/07 00:14
• Resolved: 09/Oct/06 21:26

Description

Consider an Object

public class Test {
private Object foo;

public Object get(String dummy)

{ return foo; }

public void put(String dummy, Object foo)

{ this.foo = foo }

;
}

Put this object into a Velocity Context as $test, add a HashMap as $map.

Use the following template:

$map.put("key", "val1")
$test.put("key", "val1")

$map.get("key") --> Returns val1
$test.get("key") --> Returns val1

$map.key --> Returns val1
$test.key --> Returns val1

#set ($map.key = "val2")
#set ($test.key = "val2")

$map.key --> Returns val2
$test.key --> Returns val1 !!

The reason for this is, that the UberspectorImpl, in getPropertySet tests in line 247 whether the passed object is assignable to a Map. This test is no in the getPropertyGet
and seems to have no reason because the following method lookup for "put" will succeed anyway.

I'd suggest the removal of this test.