[VELOCITY-418] FileInputStreams are not being closed so webapps cannot be undeployed.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3-rc1, 1.3, 1.3.1-rc2, 1.3.1, 1.4
• Fix Version/s: 1.5
• Environment: Deployed web app in application server. Unable to undeploy because directory cannot be deleted.
• Assignee: Unassigned
• Reporter: Jason Weinstein
• Created: 11/Nov/05 07:58
• Updated: 08/Mar/07 00:14
• Resolved: 11/Nov/05 08:59

Description

Deployed web app in application server. Unable to undeploy because directory cannot be deleted.

Example error:

Unable to delete: rm: App/App_war/org/apache/velocity/runtime/defaults/directive.properties: Permission denied

InputStreams are not being closed.

From RuntimeInstance.java

private void initializeDirectives() throws Exception
{
/*

• Initialize the runtime directive table.
• This will be used for creating parsers.
  */
  runtimeDirectives = new Hashtable();

Properties directiveProperties = new Properties();

/*

• Grab the properties file with the list of directives
• that we should initialize.
  */

InputStream inputStream =
getClass().getResourceAsStream('/' + DEFAULT_RUNTIME_DIRECTIVES);

if (inputStream == null)
throw new Exception("Error loading directive.properties! " +
"Something is very wrong if these properties " +
"aren't being located. Either your Velocity " +
"distribution is incomplete or your Velocity " +
"jar file is corrupted!");

directiveProperties.load(inputStream);

On top of this

ExtendedProperties.java does not close InputStreams which it opens.