Uploaded image for project: 'Velocity'
  1. Velocity
  2. VELOCITY-266

change AbstractContext.internalRemove() to have consistent key type

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.0-Release
    • Fix Version/s: 2.0
    • Component/s: Engine
    • Labels:
      None
    • Environment:
      Operating System: other
      Platform: All
    • Bugzilla Id:
      28605

      Description

      org.apache.velocity.context.AbstractContext.internalRemove(Object key) uses an
      argument type of java.lang.Object for the key. This is inconsistent with other
      methods (internalGet, internalPut, internalContainsKey), which all use a type
      of java.lang.String for the key.

      Of course, this will probably require deprecating it, but maybe there's still
      time to fix it, assuming few users have implemented their own.

      • Jerry Oberle
        perl -e 'printf "%silto%c%sberle%cearthlink%cnet%c", "ma", 58, "go", 64, 46,
        10;' # Sorry but I do not know whether spammers can harvest addresses from here

        Activity

        Hide
        wglass Will Glass-Husain added a comment -

        requires an API change - must wait until 2.0

        Show
        wglass Will Glass-Husain added a comment - requires an API change - must wait until 2.0
        Hide
        wglass Will Glass-Husain added a comment -

        Thanks for the suggestion. It's aminor enough issue (internal API change) that I'm going to put this as "unscheduled" until someone submits a patch.

        Show
        wglass Will Glass-Husain added a comment - Thanks for the suggestion. It's aminor enough issue (internal API change) that I'm going to put this as "unscheduled" until someone submits a patch.
        Hide
        goberle@hotmail.com Gerard Oberle added a comment -

        BTW, shouldn't the abstract internal* methods be protected rather than public?
        They're not very "internal" if they're public.

        Show
        goberle@hotmail.com Gerard Oberle added a comment - BTW, shouldn't the abstract internal* methods be protected rather than public? They're not very "internal" if they're public.

          People

          • Assignee:
            Unassigned
            Reporter:
            goberle@hotmail.com Gerard Oberle
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development