[VCL-910] Improvements to vcld -setup's VMware datastore cleanup functions

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 13/Oct/15 19:59
• Updated: 20/Jun/16 20:46
• Resolved: 20/Jun/16 20:46

Description

Some improvements could be made to the VMware datastore cleanup options available in vcld --setup:

• Purge deleted and unused images from repository datastore
• Purge deleted and unused images from virtual disk datastore

Occasionally, these functions may fail to delete a directory from a datastore – most likely because some files in the directory are locked by another host which has the same datastore mounted. Only 1 attempt is made to delete each directory. If a deletion fails due to a locked file, the directory may be partially deleted. This may prevent subsequent attempts to ignore the directory so it must be manually deleted.

I have seen cases where I can manually delete a directory immediately after the vcld --setup attempt fails. I'm not sure the reason for the failure, but multiple attempts may improve things.

The menus could also be improved. Currently, the code assembles a list of purgeable images and only allows you to select the number to delete. It would be better to be able to select the exact image revisions you want to delete.