[VCL-795] Request processes are continuously created after end time is reached if request state is 'inuse' and process initialization fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.2
• Fix Version/s: 2.4
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 20/Oct/14 14:56
• Updated: 20/Oct/14 18:11
• Resolved: 20/Oct/14 18:11

Description

vcld will continuously and perpetually attempt to process a request under these conditions:

• Request state: inuse
• Request end time has been reached (request.end is in the past)
• Processes spawned fail to initialize

An example where this can occur is for a reservation assigned to a VM and the VM host provisioning object fails to initialize. state.pm::initialize calls reservation_failed. There is a condition in reservation_failed to check for the inuse state. If inuse, the request and computer states are always set back to inuse even after the request end time has been reached. As a result, the request stays in the database forever.

There is also no delay in between attempts because vcld sees the end time has been reached and immediately makes another attempt. This causes vcld.log to grow rapidly.