[VCL-721] libvirt get_domain_info fails to properly identify vmhost's domains

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3
• Component/s: vcld (backend)
• Labels: KVM capture get_domain_info libvirt

Environment

Centos 6.2 (vm, hosted on vmhost which is ubuntu 12.04)

• Assignee: Unassigned
• Reporter: Christopher Wolfe
• Created: 30/Aug/13 14:37
• Updated: 20/Jul/16 18:15
• Resolved: 20/Jul/16 18:15

Description

During capture, when ascertaining domain names from virsh, libvirt.pm's get_domain_info function incorrectly parses the output of "virsh list --all". The regular expression to split the output line into id, name, status only captures a single space between id and name, thus resulting in additional space assigned to the name field. This extra space causes subsequent 'virsh dumpxml "<name>"' command to produce an error as virsh interprets the space to be part of the name, etc. The solution is to add a "+" in the regex after the whitespace-capture. Also for good measure, I've trimmed leading and trailing whitespace from $name after the capture.
I can't remember, off-hand, what the resulting CRITICAL error message ends up being, but it's something along the lines of "XXXHOSTXXX does not correspond to any defined virtual machine", or possibly "cannot determine the MAC address of XXXHOSTXXX