[VCL-677] xCAT2.pm displays "Use of uninitialized value in concatenation" warnings

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 27/Feb/13 16:17
• Updated: 20/Nov/14 14:44
• Resolved: 24/Sep/13 20:14

Description

There are a few places in xCAT2.pm where string values aren't checked before manipulating them which results in the following in vcld.log:

19409	2103947:2192365	new	---- WARNING ----
19409	2103947:2192365	new	2013-02-24 20:46:03	19409	2103947:2192365	new	vcld:warning_handler(613)	Use of uninitialized value in concatenation (.) or string at /usr/local/vcl/bin/../lib/VCL/Module/Provisioning/xCAT2.pm line 430.
19409	2103947:2192365	new	( 0) vcld, warning_handler (line: 613)
19409	2103947:2192365	new	(-1) xCAT2.pm, load (line: 430)
19409	2103947:2192365	new	(-2) new.pm, reload_image (line: 672)
19409	2103947:2192365	new	(-3) new.pm, process (line: 291)
19409	2103947:2192365	new	(-4) vcld, make_new_child (line: 571)
19409	2103947:2192365	new	(-5) vcld, main (line: 350)

Old code which is calling open() to run commands on the management node should be replaced with $self->mn_os->exectute and the output checked properly.