[VCL-529] invalid IP addresses are marked as valid in the is_public_ip_address

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.1
• Fix Version/s: 2.3
• Component/s: vcld (backend)
• Assignee: Unassigned
• Reporter: Aaron Coburn
• Created: 11/Oct/11 20:47
• Updated: 05/Apr/12 18:20
• Resolved: 05/Apr/12 18:20

Description

in the is_public_ip_address subroutine in utils.pm, the code first checks whether the IP address is valid. If the address is invalid, the subroutine should return 0 (i.e. the address is NOT a public IP address); instead it returns 1, and in some cases, this can result in an invalid IP address being set as the computer's public IP address.